-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/improved timer events #284
Conversation
essweine
commented
Jan 19, 2023
- Switch timer definition formats to ISO 8601
- Correct behavior of cycle timers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very thorough. Will need to test against CR-Connect to see how it holds up to those files. I do wonder if an existing library could not parse these values and would have examined more case.
Kudos, SonarCloud Quality Gate passed! |
I looked at several ISO 8601 parsing libraries, but they were generally missing support for something I needed (recurring intervals most commonly) and they didn't necessarily actually handle time deltas -- you might get something like my |