Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/inclusive gateway support #286

Merged
merged 9 commits into from
Jan 24, 2023
Merged

Feature/inclusive gateway support #286

merged 9 commits into from
Jan 24, 2023

Conversation

essweine
Copy link
Contributor

@essweine essweine commented Jan 20, 2023 •
edited
Loading

Add support for diverging inclusive gateways. This also includes

  • Pretty extensive refactors of bpmn join behavior (necessary for my sanity as I stepped through pretty much every line of code trying to figure out why inheriting from both multichoice and unstructured join didn't work)
  • Corrections to how sequence flows from gateways are handled. This fixes a bug where a flow with a condition can be promoted to a default flow if it is the only outgoing flow.

@essweine essweine marked this pull request as draft January 20, 2023 19:08
@essweine essweine marked this pull request as ready for review January 23, 2023 16:17
@essweine essweine requested review from jbirddog and danfunk January 23, 2023 16:18
jbirddog
jbirddog approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@jbirddog jbirddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion that might work but is not a blocker. lgtm.

SpiffWorkflow/bpmn/specs/InclusiveGateway.py
unfinished_paths = []
for spec in uncompleted_inputs:
if check(spec) is not None:
unfinished_paths.append(spec)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If force is True can this block be skipped? Like the if could be if not force and len(waiting_tasks) == 0. Also once you find an unfinished_path can be complete and break out of the loop?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

96.0% 96.0% Coverage
0.0% 0.0% Duplication

danfunk
danfunk approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@danfunk danfunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks vastly cleaner, very nicely done.

@essweine essweine merged commit a156378 into main Jan 24, 2023
@essweine essweine deleted the feature/inclusive-gateway-support branch January 24, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbirddog jbirddog jbirddog approved these changes

@danfunk danfunk danfunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@essweine @danfunk @jbirddog