Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequirementSet.cleanup() calls are no longer valid in pip 20.1 #62

Closed
techalchemy opened this issue Mar 5, 2020 · 0 comments · Fixed by #57
Closed

RequirementSet.cleanup() calls are no longer valid in pip 20.1 #62

techalchemy opened this issue Mar 5, 2020 · 0 comments · Fixed by #57
Labels
bug Something isn't working

Comments

@techalchemy
Copy link
Member

As of pip>=20.1, calls to RequirementSet.cleanup() are no longer valid due to the use of transient RequirementSet instances in the resolution process. This will need to be rectified throughout the codebase including in compat.resolve and in tests
@techalchemy techalchemy added the bug Something isn't working label Mar 5, 2020
techalchemy added a commit that referenced this issue Mar 5, 2020
@techalchemy
Fix test failures against pip@master
7a77147 
- Add `wheel_cache` context manager helper for managing global context
  when creating wheel wheel_cache instances
- Add optional `check_supports_wheel` argument to `Resolver.resolve()`
  call when expected arguments include this one
- Inspect `InstallRequirement.ensure_build_location()` method and
  include `autodelete` kwarg if it is expected
- Update argument types passed into `resolver.resolve` which, as of
  `pip>=20.1` will expect a list of `InstallRequirement` instances
- Update `Resolver` import path to point at new location
  (`resolution.legacy.resolver`)
- Add necessary `global_tempdir_manager` contexts in tests
- Fix expected `RequirementSet.cleanup()` call after
  `Resolver.resolve()` which no longer applies due to use of transient
  `RequirementSet`
- Fixes #58
- Fixes #59
- Fixes #60
- Fixes #61
- Fixes #62

Signed-off-by: Dan Ryan <[email protected]>
@techalchemy techalchemy mentioned this issue Mar 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compat.get_session sarugaku/pip-shims
1 participant
@techalchemy