-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new fine tuning job API #479
feat: implement new fine tuning job API #479
Conversation
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
==========================================
+ Coverage 97.07% 97.30% +0.22%
==========================================
Files 17 18 +1
Lines 719 780 +61
==========================================
+ Hits 698 759 +61
Misses 15 15
Partials 6 6
|
Hey, thank you so much for coming up with a PR for a new functionality so quickly! |
fine_tuning_job.go
Outdated
if requestParamters != "" { | ||
requestParamters += "&" | ||
} | ||
requestParamters += fmt.Sprintf("limit=%d", *parameters.limit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please use url.Values
here?
Example from https://pkg.go.dev/net/url#Values.Encode
package main
import (
"fmt"
"net/url"
)
func main() {
v := url.Values{}
v.Add("cat sounds", "meow")
v.Add("cat sounds", "mew/")
v.Add("cat sounds", "mau$")
fmt.Println(v.Encode())
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
This PR implements new Fine Tuning Job API .