Add new struct filed dimensions for embedding API #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #645 +/- ##
=======================================
Coverage 98.43% 98.44%
=======================================
Files 24 24
Lines 1345 1347 +2
=======================================
+ Hits 1324 1326 +2
Misses 15 15
Partials 6 6 ☔ View full report in Codecov by Sentry. |
embeddings.go
Outdated
| @@ -157,6 +157,9 @@ type EmbeddingRequest struct { | |||
| Model EmbeddingModel `json:"model"` | |||
| User string `json:"user"` | |||
| EncodingFormat EmbeddingEncodingFormat `json:"encoding_format,omitempty"` | |||
| // Dimensions The number of dimensions the resulting output embeddings should have. | |||
| // Only supported in text-embedding-3 and later models. | |||
| Dimensions *int `json:"dimensions,omitempty"` | |||
There was a problem hiding this comment.
Thank you for the PR!
Wouldn't int work just as well here? 0 would be ignored and all other values be included
There was a problem hiding this comment.
Thanks you sugguestion! I chang it type to int
sashabaranov
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Add new struct field
dimensionsthat support for shortening embeddings. Release in January 25, 2024Provide OpenAI documentation link
Describe your solution
Add new struct filed
Tests
manual