Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix open ai original validation. modify Tool's Function to pointer #664

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

CaoPengflying
Copy link
Contributor

Describe the change
modify Tool's Function to pointer

Provide OpenAI documentation link
https://community.openai.com/t/retrievals-tool-not-permitted/628664

Describe your solution
using pointer,Avoiding 'null' values for the 'function' field when serializing to JSON

Issue: #663

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69e3bbb) 98.44% compared to head (a1f0ba3) 98.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files          24       24           
  Lines        1347     1347           
=======================================
  Hits         1326     1326           
  Misses         15       15           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thank you!

@sashabaranov sashabaranov merged commit e8b3478 into sashabaranov:master Feb 19, 2024
3 checks passed
grulex pushed a commit to grulex/go-openai that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants