feat: provide vector store #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into vector-store
…feature/vector-strore
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
==========================================
+ Coverage 98.46% 98.89% +0.43%
==========================================
Files 24 26 +2
Lines 1364 1359 -5
==========================================
+ Hits 1343 1344 +1
+ Misses 15 9 -6
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
Thank you for updating #752 — looks good to me! |
| ) (response VectorStoresList, err error) { | ||
| urlValues := url.Values{} | ||
|
|
||
| if pagination.After != nil { |
There was a problem hiding this comment.
If you'll have time — it would be great to have a reusable func for this logic, there are 4 cases where we use it in this repo!
sashabaranov
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A similar PR may already be submitted!
Just want to finish this feature, thanks
implement vector strore api (including vector file + file batch)
https://platform.openai.com/docs/api-reference/vector-stores