Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

str-slice() should require integer indexes #2922

Closed
nex3 opened this issue Jun 25, 2019 · 0 comments · Fixed by #2949
Closed

str-slice() should require integer indexes #2922

nex3 opened this issue Jun 25, 2019 · 0 comments · Fixed by #2949
Labels
Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem

Comments

@nex3
Copy link
Contributor

nex3 commented Jun 25, 2019

str-slice("", 0.5) and str-slice("", 1, 1.5) should both throw errors because $start-at and $end-at, respectively, aren't integers. Instead in LibSass they return "".
@nex3 nex3 added the Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem label Jun 25, 2019
nschonni added a commit to nschonni/libsass that referenced this issue Jul 18, 2019
@nschonni
fix: non-integers passed to str-slice
63988e4 
See sass/sass-spec#1443
Closes sass#2922
@nschonni nschonni mentioned this issue Jul 18, 2019
Merged
nschonni added a commit to nschonni/libsass that referenced this issue Jul 18, 2019
@nschonni
fix: non-integers passed to str-slice
44e7a9e 
See sass/sass-spec#1443
Closes sass#2922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: non-integers passed to str-slice nschonni/libsass
1 participant
@nex3