-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitespace discrepancies between 3.6.1 and 3.6.2 for rule blocks in nested mode #3018
Comments
IMO it works as expected, since we changed the extend logic to match dart sass, some whitespace differences that exist in dart sass vs ruby sass are now also present in libsass. https://github.com/sass/dart-sass/blob/master/differences.md
I have no idea how OP got the spaces around the dash |
Shouldn't 3.6.2 be 3.7.0 really? |
Why? There shouldn't be any breaking changes. Only white-space issue I found when comparing bootstrap with nested mode is: input,
button {
content: outer;
&:focus {
content: inner;
}
} There we seem to loose the indentation for the preserved newline. |
Found another case which looses indentation .container {
content: outer;
@media (min-width: 30px) {
content: inner;
}
} Conclusion: we urgently need to get output mode specific spec tests back. |
I apologize if this isn't the best examples, this was tricky difficult to represent. The spacing around the / and the missing tab indent are what I'm trying to represent, but I suspect there are more issues than this, like rules having new lines between them along with no indentation. I'd recommend checking the output of multiple long stylesheets like Bootstrap to see the differences between 3.6.1 and 3.6.2. I've currently resolved this by downgrading to 3.6.1. Thanks for all the good work you're doing on the project!
input.scss
Actual results
libsass 3.6.2
Expected result
libsass 3.6.1
version info:
The text was updated successfully, but these errors were encountered: