Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utfcpp to v2.3.6 #2767

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Update utfcpp to v2.3.6 #2767

merged 1 commit into from
Nov 28, 2018

Conversation

glebm
Copy link
Contributor

@glebm glebm commented Nov 28, 2018

Updates to v2.3.6 with the following patches:

  1. Sass addition of retreat. Add retreat counterpart of advance nemtrif/utfcpp#20

  2. Fix for replace_invalid throwing on incomplete sequence at the end of the input. replace_invalid: Replace final incomplete sequence nemtrif/utfcpp#21

Fixes #2657. The buffer overflow had already been fixed in #2755. This PR also fixes the error message: previously it just said Internal Error: Not enough space, now it outputs the correct error with trace, such as:

Error: Invalid UTF-8 sequence
        on line 1:1 of ../../../tmp/libsass-2657/test_m001.txt
>> �
   ^

Fixes sass#2657

Incorporates the following utfcpp patches:

1. Sass addition of `retreat`.
   nemtrif/utfcpp#20

2. Fix for `replace_invalid` throwing on incomplete sequence at the end
   of the input.
   nemtrif/utfcpp#21
@xzyfer
Copy link
Contributor

xzyfer commented Nov 28, 2018

Thanks

@xzyfer xzyfer merged commit 2cabd11 into sass:master Nov 28, 2018
@glebm glebm deleted the utf8-update branch November 28, 2018 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddressSanitizer: buffer-overflow (OOB read) against some invalid input (sass_context.cpp:81)
2 participants