Upgrade to [email protected]

* Make `quote()` accept non-string values for bwc * Add minor testing around quotes * Add Node 14 support * Automate releases to GitHub * Bump mocha Signed-off-by: Miki <[email protected]>
sass · Jul 21, 2023 · 43c74c0 · 43c74c0
1 parent 87f3899
commit 43c74c0
Show file tree

Hide file tree

Showing 217 changed files with 20,306 additions and 17,107 deletions.
diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml
@@ -1,4 +1,4 @@
-name: Build bindings for Alpine releases
+name: Build bindings for Alpine
 
 on:
   push:
@@ -15,6 +15,7 @@ jobs:
       fail-fast: false
       matrix:
         node:
+          - 14
           - 16
           - 18
           - 19
@@ -24,6 +25,9 @@ jobs:
       - name: Install Alpine build tools
         run: apk add --no-cache python3 make git gcc g++
 
+      - name: Update NPM
+        run: npm i npm -g
+
       - uses: actions/checkout@v3
 
       - name: Install packages
@@ -35,7 +39,7 @@ jobs:
         run: npm test
 
       - uses: actions/upload-artifact@v3
-        if: github.repository_owner == 'sass' && github.event_name != 'pull_request'
+        if: github.event_name != 'pull_request'
         with:
           name: ${{ matrix.node }}
           path: vendor/
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -1,4 +1,4 @@
-name: Build bindings for Linux releases
+name: Build bindings for Linux
 
 on:
   push:
@@ -14,6 +14,10 @@ jobs:
       fail-fast: false
       matrix:
         include:
+          - node: 14
+            gcc: "gcc-8"
+            gpp: "g++-8"
+            os: ubuntu-20.04
           - node: 16
             gcc: "gcc-8"
             gpp: "g++-8"
@@ -40,6 +44,9 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
 
+      - name: Update NPM
+        run: npm i npm -g
+
       - name: Setup GCC/G++
         run: sudo apt-get install ${{ matrix.gcc }} ${{ matrix.gpp }}
 
@@ -56,7 +63,7 @@ jobs:
         run: npm test
 
       - uses: actions/upload-artifact@v3
-        if: github.repository_owner == 'sass' && github.event_name != 'pull_request'
+        if: github.event_name != 'pull_request'
         with:
           name: ${{ matrix.node }}
           path: vendor/
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
@@ -1,4 +1,4 @@
-name: Build bindings for macOS releases
+name: Build bindings for macOS
 
 on:
   push:
@@ -14,6 +14,7 @@ jobs:
       fail-fast: false
       matrix:
         node:
+          - 14
           - 16
           - 18
           - 19
@@ -27,6 +28,9 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
 
+      - name: Update NPM
+        run: npm i npm -g
+
       - name: Install packages
         run: npm install --unsafe-perm
         env:
@@ -36,7 +40,7 @@ jobs:
         run: npm test
 
       - uses: actions/upload-artifact@v3
-        if: github.repository_owner == 'sass' && github.event_name != 'pull_request'
+        if: github.event_name != 'pull_request'
         with:
           name: ${{ matrix.node }}
           path: vendor/
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -0,0 +1,203 @@
+name: Release
+
+on:
+  push:
+    tags:
+      - 'v*.*.*'
+
+env:
+  SASS_BINARY_PATH: "vendor/binding.node"
+
+jobs:
+  release-linux:
+    name: Linux release artifacts
+    runs-on: ${{ matrix.os }}
+    permissions:
+      contents: write
+    strategy:
+      matrix:
+        include:
+          - node: 14
+            gcc: "gcc-8"
+            gpp: "g++-8"
+            os: ubuntu-20.04
+          - node: 16
+            gcc: "gcc-8"
+            gpp: "g++-8"
+            os: ubuntu-20.04
+          - node: 18
+            gcc: "gcc-8"
+            gpp: "g++-8"
+            os: ubuntu-20.04
+          - node: 19
+            gcc: "gcc-8"
+            gpp: "g++-8"
+            os: ubuntu-20.04
+          - node: 20
+            gcc: "gcc-10"
+            gpp: "g++-10"
+            os: ubuntu-22.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node }}
+
+      - name: Update NPM
+        run: npm i npm -g
+
+      - name: Setup GCC/G++
+        run: sudo apt-get install ${{ matrix.gcc }} ${{ matrix.gpp }}
+
+      - name: Install
+        run: npm install --unsafe-perm
+        env:
+          SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
+          CC: ${{ matrix.gcc }}
+          CXX: ${{ matrix.gpp }}
+          LINK: ${{ matrix.gcc }}
+          LINKXX: ${{ matrix.gpp }}
+
+      - name: Get binding name
+        run: echo "ASSET_NAME=$(node -p "require('./lib/extensions.js').getBinaryName()")" >> $GITHUB_ENV
+
+      - name: Upload release artifacts
+        uses: svenstaro/upload-release-action@v2
+        with:
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: vendor/binding.node
+          asset_name: ${{ env.ASSET_NAME }}
+          tag: ${{ github.ref }}
+
+  release-alpine:
+    name: Alpine release artifacts
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    container:
+      image: node:${{ matrix.node }}-alpine
+    strategy:
+      fail-fast: false
+      matrix:
+        node:
+          - 14
+          - 16
+          - 18
+          - 19
+          - 20
+    steps:
+      - name: Alpine build tools
+        run: apk add --no-cache python3 make git gcc g++
+
+      - name: Update NPM
+        run: npm i npm -g
+
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Install
+        run: npm install --unsafe-perm
+        env:
+          SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
+
+      - name: Get binding name
+        run: echo "ASSET_NAME=$(node -p "require('./lib/extensions.js').getBinaryName()")" >> $GITHUB_ENV
+
+      - name: Upload release artifacts
+        uses: svenstaro/upload-release-action@v2
+        with:
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: vendor/binding.node
+          asset_name: ${{ env.ASSET_NAME }}
+          tag: ${{ github.ref }}
+
+  release-darwin:
+    name: Darwin release artifacts
+    runs-on: macos-latest
+    permissions:
+      contents: write
+    strategy:
+      fail-fast: false
+      matrix:
+        node:
+          - 14
+          - 16
+          - 18
+          - 19
+          - 20
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node }}
+
+      - name: Update NPM
+        run: npm i npm -g
+
+      - name: Install
+        run: npm install --unsafe-perm
+        env:
+          SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
+
+      - name: Get binding name
+        run: echo "ASSET_NAME=$(node -p "require('./lib/extensions.js').getBinaryName()")" >> $GITHUB_ENV
+
+      - name: Upload release artifacts
+        uses: svenstaro/upload-release-action@v2
+        with:
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: vendor/binding.node
+          asset_name: ${{ env.ASSET_NAME }}
+          tag: ${{ github.ref }}
+
+  release-windows:
+    name: Windows release artifacts
+    runs-on: windows-latest
+    permissions:
+      contents: write
+    strategy:
+      fail-fast: false
+      matrix:
+        node:
+          - 14
+          - 16
+          - 18
+          - 19
+          - 20
+        architecture:
+          - x64
+          - x86
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node }}
+          architecture: ${{ matrix.architecture }}
+
+      - name: Update NPM
+        run: npm i npm -g
+
+      - name: Install
+        run: npm install --unsafe-perm
+        env:
+          SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
+
+      - name: Get binding name
+        run: echo "ASSET_NAME=$(node -p "require('./lib/extensions.js').getBinaryName()")" >> $env:GITHUB_ENV
+
+      - name: Upload release artifacts
+        uses: svenstaro/upload-release-action@v2
+        with:
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: vendor/binding.node
+          asset_name: ${{ env.ASSET_NAME }}
+          tag: ${{ github.ref }}
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -1,4 +1,4 @@
-name: Build bindings for Windows releases
+name: Build bindings for Windows
 
 on:
   push:
@@ -14,6 +14,7 @@ jobs:
       fail-fast: false
       matrix:
         node:
+          - 14
           - 16
           - 18
           - 19
@@ -32,6 +33,9 @@ jobs:
           node-version: ${{ matrix.node }}
           architecture: ${{ matrix.architecture }}
 
+      - name: Update NPM
+        run: npm i npm -g
+
       - name: Install packages
         run: npm install
         env:
@@ -41,7 +45,7 @@ jobs:
         run: npm test
 
       - uses: actions/upload-artifact@v3
-        if: github.repository_owner == 'sass' && github.event_name != 'pull_request'
+        if: github.event_name != 'pull_request'
         with:
           name: ${{ matrix.node }}-${{ matrix.architecture }}
           path: |

diff --git a/lib/errors.js b/lib/errors.js
@@ -33,7 +33,7 @@ module.exports.unsupportedEnvironment = function() {
   return [
     'Node Sass does not yet support your current environment: ' + humanEnvironment(),
     'For more information on which environments are supported please see:',
-    'https://github.com/sass/node-sass/releases/tag/v' + pkg.version
+    'https://github.com/AMoo-Miki/node-sass/releases/tag/v' + pkg.version
   ].join('\n');
 };
 

diff --git a/lib/extensions.js b/lib/extensions.js
@@ -249,7 +249,7 @@ function getBinaryUrl() {
              process.env.SASS_BINARY_SITE  ||
              process.env.npm_config_sass_binary_site ||
              (pkg.nodeSassConfig && pkg.nodeSassConfig.binarySite) ||
-             'https://github.com/sass/node-sass/releases/download';
+             'https://github.com/AMoo-Miki/node-sass/releases/download';
 
   return [site, 'v' + pkg.version, getBinaryName()].join('/');
 }