Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Security] Vulnerability in lodash below 4.17.5 used by sass-graph@2 #2614

Closed
lachieh opened this issue Mar 14, 2019 · 2 comments
Closed

[Security] Vulnerability in lodash below 4.17.5 used by sass-graph@2 #2614

lachieh opened this issue Mar 14, 2019 · 2 comments

Comments

@lachieh
Copy link

lachieh commented Mar 14, 2019

https://www.npmjs.com/advisories/782

Versions of lodash before 4.17.5 are vulnerable to prototype pollution.

The vulnerable functions are 'defaultsDeep', 'merge', and 'mergeWith' which allow a malicious user to modify the prototype of Object via {constructor: {prototype: {...}}} causing the addition or modification of an existing property that will exist on all objects.

Remediation
Update to version 4.17.11 or later.

Resolution: update to sass-graph@latest. The currently used version of sass-graph is the last at v2, so some testing will be needed to upgrade to v3

I'm happy to investigate a PR, though would be helpful to understand the usage of sass-graph before I get too deep. Is there anything that has prevented the upgrade in the past?

@xzyfer
Copy link
Contributor

xzyfer commented Mar 21, 2019 via email

@quetzaluz
Copy link

quetzaluz commented Jul 26, 2019

Per lodash/lodash#4348, an upgrade is required to address a recent security vulnerability CVE-2019-10744 and now version >= 4.17.12 is recommended. This new vulnerability applies to a module used in this repo mergeWith -- I will issue a PR with another upgrade to account for this latest vulnerability.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants