Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Unsupported] Installing node-sass 4.11.0 with Node 12 #2648

Closed
Pixelatex opened this issue Apr 26, 2019 · 3 comments
Closed

[Unsupported] Installing node-sass 4.11.0 with Node 12 #2648

Pixelatex opened this issue Apr 26, 2019 · 3 comments

Comments

@Pixelatex
Copy link

3 days ago this code was being run in the build:

build	23-Apr-2019 08:31:45	Downloading binary from https://github.com/sass/node-sass/releases/download/v4.11.0/linux-x64-67_binding.node

today, it runs this code:

build	26-Apr-2019 15:26:34	Downloading binary from https://github.com/sass/node-sass/releases/download/v4.11.0/linux-x64-72_binding.node
build	26-Apr-2019 15:26:35	�[91mCannot download "https://github.com/sass/node-sass/releases/download/v4.11.0/linux-x64-72_binding.node": 
build	26-Apr-2019 15:26:35	
build	26-Apr-2019 15:26:35	HTTP error 404 Not Found

binding linux-x64-72_binding.node doesn't exist on this repo and the manual rebuild that follows afterwards crashes with several errors.

d	26-Apr-2019 15:28:39	�[91mIn file included from ../../nan/nan_converters.h:67:0,
build	26-Apr-2019 15:28:39	                 from ../../nan/nan.h:222,
build	26-Apr-2019 15:28:39	                 from ../src/binding.cpp:1:
build	26-Apr-2019 15:28:39	../../nan/nan_converters_43_inl.h: In static member function 'static Nan::imp::ToFactoryBase<v8::Boolean>::return_t Nan::imp::ToFactory<v8::Boolean>::convert(v8::Local<v8::Value>)':
build	26-Apr-2019 15:28:39	../../nan/nan_converters_43_inl.h:18:51: warning: 'v8::MaybeLocal<v8::Boolean> v8::Value::ToBoolean(v8::Local<v8::Context>) const' is deprecated: ToBoolean can never throw. Use Local version. [-Wdeprecated-declarations]
build	26-Apr-2019 15:28:39	       val->To ## TYPE(isolate->GetCurrentContext())                            \
build	26-Apr-2019 15:28:39	                                                   ^
build	26-Apr-2019 15:28:39	../../nan/nan_converters_43_inl.h:22:1: note: in expansion of macro 'X'
build	26-Apr-2019 15:28:39	 X(Boolean)
build	26-Apr-2019 15:28:39	 ^
build	26-Apr-2019 15:28:39	�[0m�[91mIn file included from /root/.node-gyp/12.0.0/include/node/v8-internal.h:14:0,
build	26-Apr-2019 15:28:39	                 from /root/.node-gyp/12.0.0/include/node/v8.h:25,
build	26-Apr-2019 15:28:39	                 from /root/.node-gyp/12.0.0/include/node/node.h:63,
build	26-Apr-2019 15:28:39	                 from ../../nan/nan.h:53,
build	26-Apr-2019 15:28:39	                 from ../src/binding.cpp:1:
build	26-Apr-2019 15:28:39	/root/.node-gyp/12.0.0/include/node/v8.h:2524:63: note: declared here
build	26-Apr-2019 15:28:39	                     V8_WARN_UNUSED_RESULT MaybeLocal<Boolean> ToBoolean(
build	26-Apr-2019 15:28:39	                                                               ^
build	26-Apr-2019 15:28:39	/root/.node-gyp/12.0.0/include/node/v8config.h:322:3: note: in definition of macro 'V8_DEPRECATE_SOON'
build	26-Apr-2019 15:28:39	   declarator __attribute__((deprecated(message)))
build	26-Apr-2019 15:28:39	   ^~~~~~~~~~
build	26-Apr-2019 15:28:39	�[0m�[91mIn file included from ../../nan/nan_converters.h:67:0,
build	26-Apr-2019 15:28:39	                 from ../../nan/nan.h:222,
build	26-Apr-2019 15:28:39	                 from ../src/binding.cpp:1:
build	26-Apr-2019 15:28:39	../../nan/nan_converters_43_inl.h: In static member function 'static Nan::imp::ValueFactoryBase<bool>::return_t Nan::imp::ToFactory<bool>::convert(v8::Local<v8::Value>)':
build	26-Apr-2019 15:28:39	../../nan/nan_converters_43_inl.h:37:57: warning: 'v8::Maybe<bool> v8::Value::BooleanValue(v8::Local<v8::Context>) const' is deprecated: BooleanValue can never throw. Use Isolate version. [-Wdeprecated-declarations]
build	26-Apr-2019 15:28:39	   return val->NAME ## Value(isolate->GetCurrentContext());                     \
build	26-Apr-2019 15:28:39	                                                         ^
build	26-Apr-2019 15:28:39	../../nan/nan_converters_43_inl.h:40:1: note: in expansion of macro 'X'
build	26-Apr-2019 15:28:39	 X(bool, Boolean)
build	26-Apr-2019 15:28:39	 ^
build	26-Apr-2019 15:28:39	�[0m�[91mIn file included from /root/.node-gyp/12.0.0/include/node/v8-internal.h:14:0,
build	26-Apr-2019 15:28:39	                 from /root/.node-gyp/12.0.0/include/node/v8.h:25,
build	26-Apr-2019 15:28:39	                 from /root/.node-gyp/12.0.0/include/node/node.h:63,
build	26-Apr-2019 15:28:39	                 from ../../nan/nan.h:53,
build	26-Apr-2019 15:28:39	                 from ../src/binding.cpp:1:
build	26-Apr-2019 15:28:39	/root/.node-gyp/12.0.0/include/node/v8.h:2562:51: note: declared here
build	26-Apr-2019 15:28:39	                 V8_WARN_UNUSED_RESULT Maybe<bool> BooleanValue(
build	26-Apr-2019 15:28:39	                                                   ^
build	26-Apr-2019 15:28:39	/root/.node-gyp/12.0.0/include/node/v8config.h:307:3: note: in definition of macro 'V8_DEPRECATED'
build	26-Apr-2019 15:28:39	   declarator __attribute__((deprecated(message)))
build	26-Apr-2019 15:28:39	   ^~~~~~~~~~
build	26-Apr-2019 15:28:39	�[0m�[91mIn file included from ../../nan/nan_new.h:189:0,
build	26-Apr-2019 15:28:39	                 from ../../nan/nan.h:223,
build	26-Apr-2019 15:28:39	                 from ../src/binding.cpp:1:
build	26-Apr-2019 15:28:39	../../nan/nan_implementation_12_inl.h: In static member function 'static Nan::imp::FactoryBase<v8::StringObject>::return_t Nan::imp::Factory<v8::StringObject>::New(v8::Local<v8::String>)':
build	26-Apr-2019 15:28:39	../../nan/nan_implementation_12_inl.h:356:37: error: no matching function for call to 'v8::StringObject::New(v8::Local<v8::String>&)'
build	26-Apr-2019 15:28:39	   return v8::StringObject::New(value).As<v8::StringObject>();
build	26-Apr-2019 15:28:39	                                     ^
build	26-Apr-2019 15:28:39	�[0m�[91mIn file included from /root/.node-gyp/12.0.0/include/node/node.h:63:0,
build	26-Apr-2019 15:28:39	                 from ../../nan/nan.h:53,
build	26-Apr-2019 15:28:39	                 from ../src/binding.cpp:1:
build	26-Apr-2019 15:28:39	/root/.node-gyp/12.0.0/include/node/v8.h:5380:23: note: candidate: static v8::Local<v8::Value> v8::StringObject::New(v8::Isolate*, v8::Local<v8::String>)
build	26-Apr-2019 15:28:39	   static Local<Value> New(Isolate* isolate, Local<String> value);
build	26-Apr-2019 15:28:39	                       ^~~
build	26-Apr-2019 15:28:39	/root/.node-gyp/12.0.0/include/node/v8.h:5380:23: note:   candidate expects 2 arguments, 1 provided
build	26-Apr-2019 15:28:39	In file included from ../../nan/nan_new.h:189:0,
build	26-Apr-2019 15:28:39	                 from ../../nan/nan.h:223,
build	26-Apr-2019 15:28:39	                 from ../src/binding.cpp:1:
build	26-Apr-2019 15:28:39	../../nan/nan_implementation_12_inl.h:356:58: error: expected primary-expression before '>' token
build	26-Apr-2019 15:28:39	   return v8::StringObject::New(value).As<v8::StringObject>();
build	26-Apr-2019 15:28:39	                                                          ^
build	26-Apr-2019 15:28:39	../../nan/nan_implementation_12_inl.h:356:60: error: expected primary-expression before ')' token
build	26-Apr-2019 15:28:39	   return v8::StringObject::New(value).As<v8::StringObject>();
build	26-Apr-2019 15:28:39	                                                            ^
build	26-Apr-2019 15:28:39	�[0m�[91mIn file included from /root/.node-gyp/12.0.0/include/node/node_object_wrap.h:26:0,
build	26-Apr-2019 15:28:39	                 from ../../nan/nan.h:55,
build	26-Apr-2019 15:28:39	                 from ../src/binding.cpp:1:
build	26-Apr-2019 15:28:39	../../nan/nan_object_wrap.h: In destructor 'virtual Nan::ObjectWrap::~ObjectWrap()':
build	26-Apr-2019 15:28:39	../../nan/nan_object_wrap.h:24:25: error: 'class Nan::Persistent<v8::Object>' has no member named 'IsNearDeath'
build	26-Apr-2019 15:28:39	     assert(persistent().IsNearDeath());
build	26-Apr-2019 15:28:39	                         ^
build	26-Apr-2019 15:28:39	�[0m�[91m../../nan/nan_object_wrap.h: In static member function 'static void Nan::ObjectWrap::WeakCallback(const v8::WeakCallbackInfo<Nan::ObjectWrap>&)':
build	26-Apr-2019 15:28:39	../../nan/nan_object_wrap.h:127:26: error: 'class Nan::Persistent<v8::Object>' has no member named 'IsNearDeath'
build	26-Apr-2019 15:28:39	     assert(wrap->handle_.IsNearDeath());
build	26-Apr-2019 15:28:39	                          ^
build	26-Apr-2019 15:28:39	�[0mbinding.target.mk:127: recipe for target 'Release/obj.target/binding/src/binding.o' failed
build	26-Apr-2019 15:28:39	make: Leaving directory '/usr/src/app/node_modules/node-sass/build'
build	26-Apr-2019 15:28:39	�[91mmake: *** [Release/obj.target/binding/src/binding.o] Error 1
@xzyfer
Copy link
Contributor

xzyfer commented Apr 26, 2019

You updated to node 12. It's not supported yet.

@xzyfer xzyfer closed this as completed Apr 26, 2019
@nschonni nschonni changed the title Linux download of bindings fails because on non-existing files. [Unsupported] Installing node-sass 4.11.0 with Node 12 Apr 26, 2019
@adamgajzlerowicz
Copy link

adamgajzlerowicz commented May 3, 2019

Took me a day to find this post and do node downgrade... All working fine now.

@t100-tank
Copy link

Node, version which is used by me is v12.2.0, using it with yarn.
Previously I installed node-sass 4.11.0 and it has raised the same problem.
I've updated node-sass to 4.12.0 , and problem disappeared.
Hope that would help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants