Update node-sass, old version not compatible with node 12 #8501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@galaxybot test this |
|
I don't think we want to update already released code with build dependency changes. I will open a PR against dev. Thanks for bringing this up. |
|
@martenson 19.05 fails to build though. |
|
Only with newer node though. |
|
@innovate-invent Are you able to use the node version shipped with Galaxy? This exact problem is why we started pinning to, autoinstalling, and using particular node versions. |
|
The node version supported in 19.05 is 10.13.0 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node 12 is not compatible with sass 4.11
sass/node-sass#2648