This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Use latest node-gyp #2819
Closed
Use latest node-gyp #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Unexpected token ) on the render example
This gets rid of "python2-only" issues
Node 4 is not supported any more.
|
I "fixed" the CI by removing older, unmaintained, node versions. Any chance to get a review on this? |
|
This cannot land of master to the breaking changes. Could you set to PR to be against the v5 branch were it is likely to land. |
|
Thank you! |
|
You actually already did it on the v5 branch. Thank you again. |
|
Please rebase out all the commits except the package.json changes. You have conflicts now because we've made changes to supported node versions on the v5 branch. |
|
Great. Thanks for the contribution. We hope to release v5 soon. |
|
Any idea when the v5 will be released? |
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of "python2-only" issues.
We also remove Node < 6 as those versions are not supported anymore. (even node 6 is not maintained)