This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Assorted lint tweaks #2903
Closed
Assorted lint tweaks #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove useless conditional in bin/node-sass; `sourceMapIsDirectory` always evaluates to true * remove unneeded else blocks * remove lonely if blocks * remove useless escape characters from regular expressions * disable use of Object.prototypes builtins directly * throw a `TypeError` instead of a generic `Error` when the options isn't an Object * specify explicitly 10 as the radix for `parseInt` * remove the path segments from require statements * remove spaces before function parentheses for consistency * replace the `package` reserved keyword in test/api.js with `pkg` * enforce end of file newlines * disallow yoda expressions * sort the ESLint rules by name so that it's easier to find a rule * lint all the files for consistency
|
It seems tests fail on Node.js 0.10 and 0.12. I will try to pinpoint why and revert the related changes. |
|
Please submit the changes separately |
|
NVM then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourceMapIsDirectoryalways evaluates to trueTypeErrorinstead of a genericErrorwhen the options isn't an ObjectparseIntpackagereserved keyword in test/api.js withpkgLet me know if you need me to make any changes 🙂
PS. I only tested this on GitHub Actions CI on my fork.
PPS. If Node.js 6.x is the minimum supported version, I guess we could use more ES6 features.EDIT: Just saw the Travis matrix.