Allow mod 0 #1229
Merged
Allow mod 0 #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match the behavior of dividing by zero, this should produce NaN rather than failing. See also #1228
This was referenced Mar 15, 2018
Merged
|
FWIW: ruby sass 3.5.6 also crashes for: foo { bar: $foo / #000000; }But since color math is deprecated I guess there is no intention to fix this ... |
|
I'm pretty confident no one will run into that issue before Ruby Sass hits end-of-life 😝. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the behavior of dividing by zero, this should produce NaN
rather than failing.
See also #1228
[skip ruby-sass]
[skip dart-sass]