Enable LibSass specs for hex colors with alpha #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
Jul 26, 2018
A deprecation for the old behaviour landed in sass#2302. This PR removes the deprecation warning for the old behaviour, and starts parsing 4 and 8 digit hex values as Colors. Looks like we had support for 8 digit hex colors for a while but somehow 4 digit support was missed. Spec sass/sass-spec#1273
xzyfer
added a commit
to xzyfer/libsass
that referenced
this pull request
Jul 26, 2018
A deprecation for the old behaviour landed in sass#2302. This PR removes the deprecation warning for the old behaviour, and starts parsing 4 and 8 digit hex values as Colors. Looks like we had support for 8 digit hex colors for a while but somehow 4 digit support was missed. Spec sass/sass-spec#1273 Fixes sass#2674
xzyfer
added a commit
to sass/libsass
that referenced
this pull request
Jul 26, 2018
A deprecation for the old behaviour landed in #2302. This PR removes the deprecation warning for the old behaviour, and starts parsing 4 and 8 digit hex values as Colors. Looks like we had support for 8 digit hex colors for a while but somehow 4 digit support was missed. Spec sass/sass-spec#1273 Fixes #2674
|
@xzyfer Can you delete LibSass-specific files when marking a spec as ignored for LibSass? |
|
Yep, sorry
…On Fri., 27 Jul. 2018, 9:14 am Natalie Weizenbaum, ***@***.***> wrote:
@xzyfer <https://github.com/xzyfer> Can you delete LibSass-specific files
<https://github.com/xzyfer/sass-spec/blob/70a653dade9d9cac5508a3fcc6dd1508c70d9323/spec/values/colors/alpha_hex/deprecation/error-libsass>
when marking a spec as ignored for LibSass?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1273 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWEhC4Yhedv4Qh5-eYWDsT45YTD9Nks5uKk1pgaJpZM4VhiWC>
.
|
|
Also, it looks like this broke Travis: https://travis-ci.org/sass/sass-spec/builds/408503694 |
|
Looks like Travis may not be pulling in the latest sassc. Libsasy defaults
to precision 5 where it looks like dart sass and ruby sass default to 10
…On Fri., 27 Jul. 2018, 9:40 am Natalie Weizenbaum, ***@***.***> wrote:
Also, it looks like this broke Travis:
https://travis-ci.org/sass/sass-spec/builds/408503694
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1273 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWGe2TQmdKw3bob7Q-gihu4nbhDyNks5uKlNfgaJpZM4VhiWC>
.
|
|
The default precision shouldn't matter; the engine sets the precision explicitly. |
|
I'm not sure what I'm missing then. sass-spec/lib/sass_spec/test_case.rb Lines 79 to 81 in 78b0f9a The default appears to be 5. I don't it being set otherwise in any relevant options.yml. Yet the output in the specs appears to use precision 10. |
|
Since no other implementation is generating the wrong precision here, it seems like it might be a LibSass bug. Can you roll back this PR while you investigate to get the build green? |
|
Oh I see what's happening here--I generated the expected test cases using Dart Sass, which always uses precision 10. |
xzyfer
added a commit
to sass/libsass
that referenced
this pull request
Nov 11, 2018
A deprecation for the old behaviour landed in #2302. This PR removes the deprecation warning for the old behaviour, and starts parsing 4 and 8 digit hex values as Colors. Looks like we had support for 8 digit hex colors for a while but somehow 4 digit support was missed. Spec sass/sass-spec#1273 Fixes #2674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip libsass]