-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for sass/libsass#2786 #1370
Conversation
Fixes sass#2786 Spec added in sass/sass-spec#1370
I know the style guide hasn't officially landed yet, but it's still a good idea to follow it for new specs. |
@nex3 Reading it now, is there anything in particular that stands out? |
@@ -0,0 +1,19 @@ | |||
<===> input.scss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read the style guide, should this then be: error/input.scss
?
|
||
-----------------------^ | ||
|
||
<===> error-dart-sass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style guide says "use dart sass output as canonical" but here Ruby and libsass have a much better error message. I've left a question on the style guide about this.
@nex3 [skip libsass] didn't seem to work here |
Oh, I thought you were a repo collaborator, but I guess not. It's a lot flakier for non-collaborators because they don't have access to the encrypted @sassbot GitHub credentials to read the commit message. I've sent you an invite to the sass-spec team. |
+1, everything a contributors need to know before submitting a new spec should be in one place.
The mechanism in the |
Thanks for the detailed feedback, I've addressed all the comments. |
812cb78
to
6c70f80
Compare
Fixes #2786 Spec added in sass/sass-spec#1370
Tests for sass/libsass#2786 fixed by sass/libsass#2860
[skip libsass]