Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for multiple language versions #1375

Merged
merged 4 commits into from
Apr 11, 2019
Merged

Drop support for multiple language versions #1375

merged 4 commits into from
Apr 11, 2019

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Apr 11, 2019

Closes #1223

@nex3 nex3 requested a review from glebm April 11, 2019 02:01
@glebm glebm requested review from xzyfer and removed request for glebm April 11, 2019 02:05
@glebm
Copy link
Contributor

glebm commented Apr 11, 2019

LGTM for the Ruby changes, still need @xzyfer to spot check the spec changes.

glebm
glebm requested changes Apr 11, 2019
View reviewed changes
lib/sass_spec/engine_adapter.rb Outdated Show resolved Hide resolved
@nex3
Copy link
Contributor Author

nex3 commented Apr 11, 2019

I don't know if @xzyfer is likely to have time to review this... he hasn't been active on the issue tracker lately (see #1361 and #1363). Can I land this for now and have him look it over later when he's got time?

@glebm
Copy link
Contributor

glebm commented Apr 11, 2019

Sure

@nex3 nex3 merged commit b1fdef8 into master Apr 11, 2019
@mgreter
Copy link
Contributor

mgreter commented Apr 12, 2019

FYI: this currently breaks libsass CI:

sass_spec/cli.rb:105:in `parse': invalid option: -V (OptionParser::InvalidOption)

Beside that there are other breaking changes from earlier commits:
https://travis-ci.org/sass/libsass/builds/515994566

@mgreter mgreter mentioned this pull request Apr 12, 2019
Merged
@mgreter
Copy link
Contributor

mgreter commented Apr 12, 2019

Fixed by sass/libsass#2865

@nex3 nex3 deleted the no-version branch April 12, 2019 00:40
@nex3
Copy link
Contributor Author

nex3 commented Apr 12, 2019

@mgreter Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glebm glebm glebm approved these changes

@xzyfer xzyfer Awaiting requested review from xzyfer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove start_version and end_version
3 participants
@nex3 @glebm @mgreter