store: fix race when iterating blocks (thanos-io#6675)

Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode · Aug 31, 2023 · 2bad830 · 2bad830
1 parent 5bf3a9e
commit 2bad830
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/store/bucket.go b/pkg/store/bucket.go
@@ -1693,6 +1693,9 @@ func (s *BucketStore) LabelNames(ctx context.Context, req *storepb.LabelNamesReq
 }
 
 func (s *BucketStore) UpdateLabelNames() {
+	s.mtx.RLock()
+	defer s.mtx.RUnlock()
+
 	newSet := stringset.New()
 	for _, b := range s.blocks {
 		labelNames, err := b.indexHeaderReader.LabelNames()