Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to astro 4.0 #187

Closed
alec-c4 opened this issue Dec 13, 2023 · 12 comments
Closed

Upgrade to astro 4.0 #187

alec-c4 opened this issue Dec 13, 2023 · 12 comments

Comments

@alec-c4
Copy link

alec-c4 commented Dec 13, 2023

As you maybe know - Astro 4 have arrived. Are there any plans to upgrade AstroPaper to a new version?

@satnaing
Copy link
Owner

satnaing commented Dec 14, 2023

Of course, I'll upgrade to Astro v4.
However, at the moment, I've been trying to solve some issues.
After that, I'll upgrade.

Busy these days 😅
Thanks for reminding me.

@diomed
Copy link
Contributor

diomed commented Dec 15, 2023

how could I send you my own theme scheme suggestion?
maybe here?

would you update with it?

@o-t-w
Copy link

o-t-w commented Dec 18, 2023

I built my blog when this theme was using version 2 of Astro. I've had huge problems trying to upgrade. Do you have any advice? This is the issue I created in the Astro Discord channel

@vasfvitor
Copy link

With just pnpm dlx @astrojs/upgrade it upgrades and builds normally. I went quickly through https://docs.astro.build/en/guides/upgrade-to/v4/ but any changes that might needed was already addressed

btw, is shamefully-hoist=true still needed? I remember this being a thing but now I guess it not necessary,
https://discord.com/channels/830184174198718474/845430950191038464/1024702697938632734.

@jeanlucaslima
Copy link

@satnaing if you need any help just create some issues and we can contribute.

@diomed
Copy link
Contributor

diomed commented Dec 21, 2023

@satnaing if you need any help just create some issues and we can contribute.
@jeanlucaslima you can even contribute without issues. just by sending PR's. he'll accept if ok.

@jeanlucaslima
Copy link

@diomed are you sure? Not all repos are like this.

@jeanlucaslima
Copy link

Just did on #200

@satnaing
Copy link
Owner

how could I send you my own theme scheme suggestion? maybe here?

would you update with it?

Yep. @diomed
I'll make a PR for v4 upgrade and you can suggest under that.

@satnaing
Copy link
Owner

@satnaing if you need any help just create some issues and we can contribute.

Appreciate it.
You all can give suggestions and feedback (maybe contribute) on my v4 PR later.

@satnaing
Copy link
Owner

I built my blog when this theme was using version 2 of Astro. I've had huge problems trying to upgrade. Do you have any advice? This is the issue I created in the Astro Discord channel

@o-t-w sorry to hear your inconvenience
Maybe you can try by following this article?
As a maintainer, it's hard to cover a lot of use cases and different customizations.

On one hand, there're new breaking changes and features by Astro itself, plus some additional features by AstroPaper. On the other hand, there are a lot of users (like you) who want to upgrade smoothly.
One of the easiest way to upgrade, in my opinion, is saving your customizations and contents, get the latest AstroPaper, then apply your previous customizations accordingly.

There might be some better ways to do this. So let me know if you guys have better approach. Maybe changes I have to make for better customizations.

satnaing added a commit that referenced this issue Dec 29, 2023
Bump astro v3.6.4 to v4.0.9 (major upgrade). Bump astrojs/rss v3.0.0 to 4.0.1 (major upgrade). Upgrade other astro related packages.

BREAKING CHANGE: Astro v4 upgrade

Closes: #187
@jeanlucaslima
Copy link

@satnaing if you need any help just create some issues and we can contribute.
@jeanlucaslima you can even contribute without issues. just by sending PR's. he'll accept if ok.

Like I said... Not all repos like outside PRs :^) no hard feelings, it's just common

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants