Inter-process communication #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpfs
changed the title
To indicate whether an initial sync should create the account on the remote (push) or on local (pull).
Prepare to support accounts that are uninitialized with no storage.
To initialize an account from patches loaded using the sync protocol CreateSet; used so that linked accounts can be created during a sync operation.
And send a RESET_CONTENT HTTP message over stdout in the extension helper.
The variable must be set at compile time and debug_assertions must be enabled.
So that RESET_CONTENT notifications only reflect the latest changes correctly.
Write AccountEvent and WriteEvent by hand due to the typeshare limitations.
So that the extension when responding to reset content events loads the up to date secret information.
When serde sees a tuple enum variant with two entries but the last one is set to skip then it encodes as an array of one item, however in the case of WriteEvent::DeleteSecret it's a single item and the containing array is skipped. I suspect because it is serialized using the new type logic.
Need to reload the vault before updating the search index when responding to external changes in the extension helper.
Needs work to debug why the channel is being closed prematurely.
Watch the identity event log for changes rather than the account events because changes to the account events would fire earlier than changes to the identity folder making it hard to reconcile when the new folder password would have been saved in the identity folder. By watching the identity folder event log instead we know that we can reload the identity folder to access the new folder password which is required to make watching work well when new secrets are created within a new folder.
The notify-types crate has already been updated to use web-time but we need a new release on crates.io to be able to remove the dependency on instant from the dependency tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #561 and closes #588.