Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract REDUNDANT_SEMICOLON rule check from the logic associated with WRONG_NEWLINES #1863

Closed
DrAlexD opened this issue Dec 14, 2023 · 0 comments · Fixed by #1864
Closed

Extract REDUNDANT_SEMICOLON rule check from the logic associated with WRONG_NEWLINES #1863

DrAlexD opened this issue Dec 14, 2023 · 0 comments · Fixed by #1864
Assignees
@DrAlexD
Labels
bug Something isn't working
Milestone
2.0.0

Comments

@DrAlexD
Copy link
Member

DrAlexD commented Dec 14, 2023

No description provided.

@DrAlexD DrAlexD added the bug Something isn't working label Dec 14, 2023
@DrAlexD DrAlexD self-assigned this Dec 14, 2023
@DrAlexD DrAlexD added this to the 2.0.0 milestone Dec 14, 2023
DrAlexD added a commit that referenced this issue Dec 14, 2023
@DrAlexD
Extracted REDUNDANT_SEMICOLON rule check from logic associated with…
94de235 
… `WRONG_NEWLINES` rule

### What's done:
- `REDUNDANT_SEMICOLON` rule check moved to earlier checks to remove unnecessary semicolons before executing the rest of the rules.
- Moved several warning and fix tests related to `REDUNDANT_SEMICOLON` rule.

Closes #1863, #1783
@DrAlexD DrAlexD mentioned this issue Dec 14, 2023
Merged
DrAlexD added a commit that referenced this issue Dec 15, 2023
@DrAlexD
Extracted REDUNDANT_SEMICOLON rule check from WRONG_NEWLINES rule (…
3e3740e 
…#1864)

### What's done:
- `REDUNDANT_SEMICOLON` rule check moved to earlier checks to remove unnecessary semicolons before executing the rest of the rules.
- Moved several warning and fix tests related to `REDUNDANT_SEMICOLON` rule.
- Added smoke test for logic related to semicolons.
- Added warning test for `LocalVariablesRule`.

Closes #1863, #1783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DrAlexD DrAlexD

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Extracted REDUNDANT_SEMICOLON rule check from WRONG_NEWLINES rule saveourtool/diktat
1 participant
@DrAlexD