[#1347] Clean up the code #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1376 +/- ##
============================================
- Coverage 83.53% 83.46% -0.07%
+ Complexity 2552 2546 -6
============================================
Files 106 107 +1
Lines 7517 7543 +26
Branches 2081 2082 +1
============================================
+ Hits 6279 6296 +17
- Misses 359 367 +8
- Partials 879 880 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nulls
reviewed
Jun 20, 2022
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/IndentationRule.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/IndentationRule.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/IndentationRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter3/files/IndentationRule.kt
Show resolved
Hide resolved
...at-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/spaces/IndentationRuleTestMixin.kt
Show resolved
Hide resolved
petertrr
approved these changes
Jun 20, 2022
0x6675636b796f75676974687562
force-pushed
the
feature/andrey.shcheglov/indentation-unit-tests
branch
2 times, most recently
from
d2e9455
to
78b76a4
Compare
### What's done: * Code cleaned up in preparation to settle #1347. * No logic is modified with this change.
### What's done: * `IndentationError` moved to a separate source file. * Top-level extensions moved from `IndentationRule.kt` to `StringUtils.kt`.
0x6675636b796f75676974687562
force-pushed
the
feature/andrey.shcheglov/indentation-unit-tests
branch
from
78b76a4
to
0a3a32f
Compare
0x6675636b796f75676974687562
deleted the
feature/andrey.shcheglov/indentation-unit-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
WRONG_INDENTATION: runningmvn diktat:fixadds whitespace to string literals #1347.