Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated DistributiveLaw to jbool implementation #1513

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Conversation

nulls
Copy link
Member

@nulls nulls commented Sep 2, 2022

What's done:

  • changed version of jbool
  • removed DistributiveLaw implementation in diktat

@nulls nulls self-assigned this Sep 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 914 tests   1 899 ✔️  1m 10s ⏱️
   159 suites       15 💤
   159 files           0

Results for commit cdd1a77.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 929 tests   1 914 ✔️  3m 36s ⏱️
   160 suites       15 💤
   160 files           0

Results for commit 42afe54.

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1513 (cdd1a77) into master (b5ef51d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1513      +/-   ##
============================================
- Coverage     82.76%   82.74%   -0.03%     
  Complexity     2565     2565              
============================================
  Files           111      111              
  Lines          7723     7695      -28     
  Branches       2121     2113       -8     
============================================
- Hits           6392     6367      -25     
+ Misses          432      431       -1     
+ Partials        899      897       -2     
Flag Coverage Δ
unittests 82.74% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/ruleset/rules/chapter3/BooleanExpressionsRule.kt 92.66% <ø> (+0.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

--- What's done:
* changed version of jbool
* removed DistributiveLaw implementation in diktat
@nulls nulls merged commit 2ae3500 into master Sep 5, 2022
@nulls nulls deleted the feature/jbool branch September 5, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants