Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAVE smoke tests should not have fixed line numbers #1528

Merged
merged 9 commits into from
Sep 16, 2022

Conversation

Cheshiriks
Copy link
Member

What's done:

### What's done:
* replace line numbers with placeholder
Closes #1527
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1528 (895f520) into master (cf9bce0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1528   +/-   ##
=========================================
  Coverage     82.59%   82.59%           
  Complexity     2577     2577           
=========================================
  Files           111      111           
  Lines          7756     7756           
  Branches       2127     2127           
=========================================
  Hits           6406     6406           
  Misses          443      443           
  Partials        907      907           
Flag Coverage Δ
unittests 82.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 938 tests   1 923 ✔️  3m 11s ⏱️
   160 suites       15 💤
   160 files           0

Results for commit 895f520.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 923 tests   1 908 ✔️  1m 37s ⏱️
   159 suites       15 💤
   159 files           0

Results for commit 895f520.

♻️ This comment has been updated with latest results.

Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, that we should give a good example for everyone with these tests. Let's remove line numbers

### What's done:
* replace line numbers with placeholder
Closes #1527
### What's done:
* replace line numbers with placeholder
Closes #1527
### What's done:
* replace line numbers with placeholder
Closes #1527
### What's done:
* replace line numbers with placeholder
Closes #1527
### What's done:
* replace line numbers with placeholder
Closes #1527
### What's done:
* replace line numbers with placeholder
Closes #1527
### What's done:
* replace line numbers with placeholder
Closes #1527
@Cheshiriks Cheshiriks merged commit f6fa2cd into master Sep 16, 2022
@Cheshiriks Cheshiriks deleted the feature/delete-line-warning branch September 16, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAVE smoke tests SHOULD NOT have fixed line numbers!
2 participants