Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite StreamGobbler #1692

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Rewrite StreamGobbler #1692

merged 4 commits into from
Jun 13, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Jun 9, 2023

What's done:

  • rewrite StreamGobbler to kotlinx coroutines

### What's done:
- rewrite StreamGobbler to kotlinx coroutines
@nulls nulls added this to the 2.0.0 milestone Jun 9, 2023
@nulls nulls self-assigned this Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1692 (f92f29d) into master (d7d39f0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1692   +/-   ##
=========================================
  Coverage     78.72%   78.72%           
  Complexity     2317     2317           
=========================================
  Files           124      124           
  Lines          8151     8151           
  Branches       2062     2062           
=========================================
  Hits           6417     6417           
  Misses          826      826           
  Partials        908      908           

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   162 files  ±0     162 suites  ±0   11m 9s ⏱️ -49s
1 371 tests ±0  1 335 ✔️ ±0  36 💤 ±0  0 ±0 
2 750 runs  ±0  2 714 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit f92f29d. ± Comparison against base commit d7d39f0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   162 files  ±0     162 suites  ±0   6m 58s ⏱️ - 4m 44s
1 371 tests ±0  1 354 ✔️ ±0  17 💤 ±0  0 ±0 
2 750 runs  ±0  2 733 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit f92f29d. ± Comparison against base commit d7d39f0.

♻️ This comment has been updated with latest results.

@nulls nulls enabled auto-merge (squash) June 13, 2023 09:53
@nulls nulls merged commit 4f23c71 into master Jun 13, 2023
@nulls nulls deleted the feature/stream-globber branch June 13, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants