Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored warn and warnAndFix in Warnings #1751

Merged
merged 8 commits into from
Sep 26, 2023
Merged

Conversation

nulls
Copy link
Member

@nulls nulls commented Sep 25, 2023

What's done:

  • removed isFixMode from warn
  • removed canBeAutoCorrected from warnAndFix

It closes #1748

### What's done:
- removed `isFixMode` from `warn`
- removed `canBeAutoCorrected` from `warnAndFix`

It closes #1748
@nulls nulls added enhancement New feature or request tests Improve testing labels Sep 25, 2023
@nulls nulls added this to the 2.0.0 milestone Sep 25, 2023
@nulls nulls self-assigned this Sep 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   5m 16s ⏱️ -3s
1 380 tests ±0  1 321 ✔️ ±0  59 💤 ±0  0 ±0 
2 759 runs  ±0  2 699 ✔️ ±0  60 💤 ±0  0 ±0 

Results for commit d955137. ± Comparison against base commit 3c4e688.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   5m 18s ⏱️ +29s
1 380 tests ±0  1 333 ✔️ ±0  47 💤 ±0  0 ±0 
2 759 runs  ±0  2 711 ✔️ ±0  48 💤 ±0  0 ±0 

Results for commit d955137. ± Comparison against base commit 3c4e688.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1751 (d955137) into master (3c4e688) will increase coverage by 0.07%.
The diff coverage is 93.87%.

@@             Coverage Diff              @@
##             master    #1751      +/-   ##
============================================
+ Coverage     76.40%   76.47%   +0.07%     
- Complexity     2296     2297       +1     
============================================
  Files           126      126              
  Lines          8273     8290      +17     
  Branches       2081     2080       -1     
============================================
+ Hits           6321     6340      +19     
+ Misses         1027     1024       -3     
- Partials        925      926       +1     
Files Coverage Δ
.../diktat/ruleset/rules/chapter1/IdentifierNaming.kt 82.88% <100.00%> (+1.93%) ⬆️
...ool/diktat/ruleset/rules/chapter1/PackageNaming.kt 88.42% <100.00%> (ø)
...at/ruleset/rules/chapter2/comments/CommentsRule.kt 87.50% <ø> (-0.15%) ⬇️
...leset/rules/chapter2/comments/HeaderCommentRule.kt 87.40% <100.00%> (ø)
...diktat/ruleset/rules/chapter2/kdoc/KdocComments.kt 81.81% <100.00%> (ø)
...ktat/ruleset/rules/chapter2/kdoc/KdocFormatting.kt 86.42% <100.00%> (ø)
.../diktat/ruleset/rules/chapter2/kdoc/KdocMethods.kt 73.58% <100.00%> (ø)
...ol/diktat/ruleset/rules/chapter3/DebugPrintRule.kt 79.41% <100.00%> (ø)
...urtool/diktat/ruleset/rules/chapter3/EmptyBlock.kt 77.61% <100.00%> (ø)
...urtool/diktat/ruleset/rules/chapter3/LineLength.kt 56.34% <100.00%> (+0.23%) ⬆️
... and 32 more

Copy link
Member

@kgevorkyan kgevorkyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you change in some rules argument canBeAutocorrected from true to false
could you please update corresponding .md files? avaliable-rules and so on

@nulls nulls disabled auto-merge September 26, 2023 09:00
@nulls
Copy link
Member Author

nulls commented Sep 26, 2023

I see that you change in some rules argument canBeAutocorrected from true to false could you please update corresponding .md files? avaliable-rules and so on

changed only AVOID_NULL_CHECKS in Warnings. Updated rules-mapping.md and available-rules.md (there already was marked as fix, updated notes only)

@nulls nulls enabled auto-merge (squash) September 26, 2023 09:07
@nulls nulls merged commit aa26135 into master Sep 26, 2023
@nulls nulls deleted the feature/warn_and_fix#1748 branch September 26, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Improve testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish login in Warnings
2 participants