-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored warn
and warnAndFix
in Warnings
#1751
Conversation
### What's done: - removed `isFixMode` from `warn` - removed `canBeAutoCorrected` from `warnAndFix` It closes #1748
JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 5m 16s ⏱️ -3s Results for commit d955137. ± Comparison against base commit 3c4e688. ♻️ This comment has been updated with latest results. |
JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2) 164 files ±0 164 suites ±0 5m 18s ⏱️ +29s Results for commit d955137. ± Comparison against base commit 3c4e688. ♻️ This comment has been updated with latest results. |
Codecov Report
@@ Coverage Diff @@
## master #1751 +/- ##
============================================
+ Coverage 76.40% 76.47% +0.07%
- Complexity 2296 2297 +1
============================================
Files 126 126
Lines 8273 8290 +17
Branches 2081 2080 -1
============================================
+ Hits 6321 6340 +19
+ Misses 1027 1024 -3
- Partials 925 926 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you change in some rules argument canBeAutocorrected
from true
to false
could you please update corresponding .md files? avaliable-rules
and so on
diktat-rules/src/main/kotlin/com/saveourtool/diktat/ruleset/constants/Warnings.kt
Show resolved
Hide resolved
changed only |
What's done:
isFixMode
fromwarn
canBeAutoCorrected
fromwarnAndFix
It closes #1748