Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed maven plugin #1816

Merged
merged 10 commits into from
Nov 23, 2023
Merged

Fixed maven plugin #1816

merged 10 commits into from
Nov 23, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Nov 22, 2023

What's done:

  • fixed checking configFile
  • restored logic for input and exclude in maven plugin (removed in Diktat API #1655)
  • fixed warning about provided dependency in maven plugin

It closes #1814

@nulls nulls self-assigned this Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (b01cd64) 78.72% compared to head (6211a81) 78.62%.

Files Patch % Lines
.../saveourtool/diktat/plugin/maven/DiktatBaseMojo.kt 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1816      +/-   ##
============================================
- Coverage     78.72%   78.62%   -0.11%     
  Complexity     2441     2441              
============================================
  Files           126      126              
  Lines          8544     8555      +11     
  Branches       2163     2163              
============================================
  Hits           6726     6726              
- Misses          850      861      +11     
  Partials        968      968              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 22, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 52s ⏱️ -11s
1 397 tests ±0  1 380 ✔️ ±0  17 💤 ±0  0 ±0 
2 776 runs  ±0  2 759 ✔️ ±0  17 💤 ±0  0 ±0 

Results for commit 6211a81. ± Comparison against base commit b01cd64.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 22, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   7m 22s ⏱️ - 1m 39s
1 397 tests ±0  1 361 ✔️ ±0  36 💤 ±0  0 ±0 
2 776 runs  ±0  2 740 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit 6211a81. ± Comparison against base commit b01cd64.

♻️ This comment has been updated with latest results.

@nulls nulls marked this pull request as ready for review November 22, 2023 14:34
@nulls nulls enabled auto-merge (squash) November 22, 2023 15:25
@nulls nulls merged commit b5c1a37 into master Nov 23, 2023
20 of 21 checks passed
@nulls nulls deleted the feature/fix-maven-plugin#1814 branch November 23, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration file diktat-analysis.yml doesn't exist
3 participants