-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/consistent codestyle 0.1.5 #556
Conversation
### What's done: * Code style
### What's done: * Code style
….5' into feature/consistent-codestyle-0.1.5
…codestyle-0.1.5 # Conflicts: # diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt # diktat-maven-plugin/src/main/kotlin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/classes/SingleInitRule.kt
### What's done: * Compilation fixes
### What's done: * Fixes
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
============================================
+ Coverage 80.82% 81.33% +0.51%
- Complexity 1712 1720 +8
============================================
Files 87 87
Lines 4385 4548 +163
Branches 1351 1359 +8
============================================
+ Hits 3544 3699 +155
- Misses 298 306 +8
Partials 543 543
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Fixing code style
### What's done: * Fixing code style
### What's done: * Fixing code style in tests
### What's done: * Fixing code style in tests
….5' into feature/consistent-codestyle-0.1.5
### What's done: * Fixing code style
### What's done: * Fixing code style in tests
### What's done: * Fixing code style
### What's done: * Fixing code style
### What's done: * Fixing code style
### What's done: * Fixing code style
…codestyle-0.1.5 # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/kdoc/KdocComments.kt # diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter2/KdocCommentsWarnTest.kt
### What's done: * Fixing code style
### What's done: * Fixing code style * Update diktat-analysis.yml
### What's done: * Fixing code style
### What's done: * Fixing code style
### What's done: * Fixing code style
…codestyle-0.1.5 # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/BracesInConditionalsAndLoopsRule.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt
### What's done: * Fixes after merge
### What's done: * Fixing code style
### What's done: * Fixing code style
…codestyle-0.1.5 # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/kdoc/KdocMethods.kt
### What's done: * Fixing code style
…codestyle-0.1.5 # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/NullChecksRule.kt # diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter4/NullChecksRuleWarnTest.kt
### What's done: * Fixing code style
### What's done: * Fixing code style
### What's done: * Fixing code style
### What's done: * fixing AVOID_NULL_CHECKS
…codestyle-0.1.5 # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/files/WhiteSpaceRule.kt
### What's done: * fixing code style
### What's done: * fixing AVOID_NULL_CHECKS
### What's done: * fixing code style
### What's done: * detekt
### What's done: * fixes
…codestyle-0.1.5 # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/EmptyBlock.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt
### What's done: * fixes after merge
### What's done: * fixing code style
### What's done: * Suppressed WRONG_NEWLINES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Currently blocked by
#325, #492,#550,#551,#480,#585,#490It would be nice to do #574 to make fixing of tests simpler, but it can be done later and then run against current code once more.
Now only 800 errors are left.Only
34529421138 to go!