Support GitHub actions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added libs.versions.toml support * Added diktat and detekt gradle plugins * Added buildSrc module for diktat and detekt configuration * Added GitHub hooks for linters and test checks
nulls
reviewed
Apr 10, 2023
### What's done: * Added libs.versions.toml support * Added diktat and detekt gradle plugins * Added buildSrc module for diktat and detekt configuration * Added GitHub hooks for linters and test checks
0x6675636b796f75676974687562
approved these changes
Apr 10, 2023
nulls
requested changes
Apr 10, 2023
### What's done: * Added libs.versions.toml support * Added diktat and detekt gradle plugins * Added buildSrc module for diktat and detekt configuration * Added GitHub hooks for linters and test checks
nulls
approved these changes
Apr 10, 2023
buildSrc/src/main/kotlin/com/saveourtool/processbuilder/DiktatConfiguration.kt
Outdated
Show resolved
Hide resolved
### What's done: * Added libs.versions.toml support * Added diktat and detekt gradle plugins * Added buildSrc module for diktat and detekt configuration * Added GitHub hooks for linters and test checks
### What's done: * Added libs.versions.toml support * Added diktat and detekt gradle plugins * Added buildSrc module for diktat and detekt configuration * Added GitHub hooks for linters and test checks
### What's done: * Added libs.versions.toml support * Added diktat and detekt gradle plugins * Added buildSrc module for diktat and detekt configuration * Added GitHub hooks for linters and test checks
nulls
reviewed
Apr 10, 2023
| output.set(buildDir.resolve("detekt-sarif-reports/detekt-merged.sarif")) | ||
| } | ||
|
|
||
| @Suppress("GENERIC_VARIABLE_WRONG_DECLARATION") | ||
| val reportMerge: TaskProvider<ReportMergeTask> = rootProject.tasks.named<ReportMergeTask>("mergeDetektReports") { |
There was a problem hiding this comment.
it's the same task as created on prev line tasks.register("mergeDetektReports", ReportMergeTask::class) {
why not merged them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
libs.versions.tomlsupportdiktatanddetektgradle pluginsbuildSrcmodule fordiktatanddetektconfiguration