Allowing for order! to be a string key #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using savon to issue SOAP requests in a background process, the request parameters (a hash) get saved by resque in redis. When pulled out of redis, all keys of the hash are stringified as they are marshalled as strings. In order to avoid ordering issues when using resque or sidekick, gyoku will accept both the symbol or the string version of the order! key and respect that order.
|
Thanks for the pull request @hugocorbucci. I'm sorry it took me so many weeks to respond to this issue -- I certainly didn't want to keep you waiting for a response this long. This issue is a bit of an edge case, but it seems like a perfectly fine change that has a very low risk of ever hurting anyone but... it does make the public API a little bit inconsistent. |
tjarratt
added a commit
that referenced
this pull request
Aug 27, 2014
Allowing for order! to be a string key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using savon to issue SOAP requests in a background process, the
request parameters (a hash) get saved by resque in redis. When pulled
out of redis, all keys of the hash are stringified as they are
marshalled as strings.
In order to avoid ordering issues when using resque or sidekick, gyoku
will accept both the symbol or the string version of the order! key and
respect that order.
This way savon can take whatever comes from those backgrounding tools and convert it to XML without having to worry about deeply reconverting everything to symbols.