Deprecate sonatypeRepo, add sonatypeOssRepos to Resolver
#393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
force-pushed
the
feature/sonatypeRepos
branch
from
dcb7b1a to
c17309a
Compare
eed3si9n
reviewed
Jan 31, 2022
armanbilge
changed the title
sonatypeRepo, add sonatypeRepos to ResolversonatypeRepo, add sonatypeOssRepos to Resolver
|
@eed3si9n do you think this one might land in sbt 1.7.0? |
eed3si9n
approved these changes
May 7, 2022
|
@armanbilge yea. 🚢 it. |
tanishiking
added a commit
to tanishiking/metals
that referenced
this pull request
Jul 20, 2022
After updating sbt to 1.7.0, we started to get the following warnings
on startup of sbt.
```
/Users/tanishiking/src/github.com/tanishiking/metals/build.sbt:57: warning: method sonatypeRepo in class ResolverFunctions is deprecated (since 1.7.0): Use sonatypeOssRepos instead
resolvers += Resolver.sonatypeRepo("public"),
^
/Users/tanishiking/src/github.com/tanishiking/metals/build.sbt:58: warning: method sonatypeRepo in class ResolverFunctions is deprecated (since 1.7.0): Use sonatypeOssRepos instead
resolvers += Resolver.sonatypeRepo("snapshot"),
``` ^
As the original PR to sbt/librarymanagement says, `sonatyOssRepos` add
`https://s01.oss.sonatype.org` in addition to
`https://oss.sonatype.org`.
sbt/librarymanagement#393
for more information: https://central.sonatype.org/news/20210223_new-users-on-s01/
tanishiking
added a commit
to scalameta/metals
that referenced
this pull request
Jul 20, 2022
After updating sbt to 1.7.0, we started to get the following warnings
on startup of sbt.
```
/Users/tanishiking/src/github.com/tanishiking/metals/build.sbt:57: warning: method sonatypeRepo in class ResolverFunctions is deprecated (since 1.7.0): Use sonatypeOssRepos instead
resolvers += Resolver.sonatypeRepo("public"),
^
/Users/tanishiking/src/github.com/tanishiking/metals/build.sbt:58: warning: method sonatypeRepo in class ResolverFunctions is deprecated (since 1.7.0): Use sonatypeOssRepos instead
resolvers += Resolver.sonatypeRepo("snapshot"),
``` ^
As the original PR to sbt/librarymanagement says, `sonatyOssRepos` add
`https://s01.oss.sonatype.org` in addition to
`https://oss.sonatype.org`.
sbt/librarymanagement#393
for more information: https://central.sonatype.org/news/20210223_new-users-on-s01/
rtyley
added a commit
to guardian/frontend
that referenced
this pull request
Dec 21, 2022
In February 2021 Sonatype started spreading its OSS Maven artifact hosting across 2 repository hosts, so we need to use the plural `sonatypeOssRepos` (introduced with sbt/librarymanagement#393) rather than the deprecated singular `sonatypeRepo`. https://central.sonatype.org/news/20210223_new-users-on-s01/ I managed to miss this when I was doing #25781, tho' I caught it elsewhere! #25781 (comment)
emdash-ie
added a commit
to guardian/support-frontend
that referenced
this pull request
May 19, 2023
The latter [has been deprecated](sbt/librarymanagement#393). I don’t fully understand why, but the new function uses both old and new sonatype repos somehow.
emdash-ie
added a commit
to guardian/support-frontend
that referenced
this pull request
May 19, 2023
The latter [has been deprecated](sbt/librarymanagement#393). I don’t fully understand why, but the new function uses both old and new sonatype repos somehow.
emdash-ie
added a commit
to guardian/support-frontend
that referenced
this pull request
May 19, 2023
The latter [has been deprecated](sbt/librarymanagement#393). I don’t fully understand why, but the new function uses both old and new sonatype repos somehow.
emdash-ie
added a commit
to guardian/support-frontend
that referenced
this pull request
May 19, 2023
The latter [has been deprecated](sbt/librarymanagement#393). I don’t fully understand why, but the new function uses both old and new sonatype repos somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Riffing on #392 (comment).
Since sonatype has indicated they may/will add additional hosts, this seems like the most sensible way forward.
https://central.sonatype.org/news/20210223_new-users-on-s01/#why-are-we-doing-this