githubWorkflowUseSbtThinClient should default to false due to current issues

[mdedetrich]

This is more of a suggestion but it seems like a lot of people are having problems with sbt's thin client mode (see sbt/sbt#6468). An issue I just found is that currently when SBT runs with --client it ignores all environment variables which makes the env field for WorkflowStep.Sbt not even work (you can see the PR at iheartradio/ficus#155 where I had to set this to false because sbt-coveralls cannot even pick up the env vars)

My suggestion would be to set it completely to false until the problems with a new SBT release.

[armanbilge]

+1. See typelevel/cats#3952 and http4s/http4s#4938 (comment).

[mdedetrich]

@djspiewak Shall I close the issue or do you want me to leave it open?

[armanbilge]

@mdedetrich pretty sure this will be addressed, lots of projects are making this change including typelevel/cats-effect#2150 (comment).

[djspiewak]

Ah, didn't realize it wasn't linked. This is fixed in main and will be released soon

[yanns]

https://github.com/djspiewak/sbt-github-actions still documents the following:

githubWorkflowUseSbtThinClient : Boolean – [...] (default: true for sbt ≥ 1.4, false otherwise)

Is it still true?

[mdedetrich]

@yanns I think you are right, just made a PR for it here #101