Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chrome to CI matrix #2150

Merged
merged 11 commits into from
Jul 30, 2021
Merged

Add chrome to CI matrix #2150

merged 11 commits into from
Jul 30, 2021

Conversation

armanbilge
Copy link
Member

Let's see what happens.

djspiewak
djspiewak reviewed Jul 24, 2021
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
vasilmkd
vasilmkd requested changes Jul 29, 2021
View reviewed changes
Copy link
Member

@vasilmkd vasilmkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@armanbilge armanbilge requested review from vasilmkd and djspiewak July 29, 2021 18:11
djspiewak
djspiewak previously approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@djspiewak djspiewak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Needs conflict resolution but otherwise this is awesome

Edit Oh it's already resolved. Okay perfect. :-D

armanbilge
armanbilge commented Jul 30, 2021
View reviewed changes
build.sbt Show resolved Hide resolved
@armanbilge armanbilge marked this pull request as draft July 30, 2021 04:03
@armanbilge
Copy link
Member Author

Sorry don't merge yet!! Need to get webworker going on Chrome.

@armanbilge armanbilge marked this pull request as ready for review July 30, 2021 05:46
@armanbilge armanbilge requested a review from djspiewak July 30, 2021 05:46
armanbilge
armanbilge commented Jul 30, 2021
View reviewed changes
build.sbt Show resolved Hide resolved
@armanbilge
Copy link
Member Author

Would you accept a PR disabling sbt --client?

@vasilmkd
Copy link
Member

Very cool work.

@djspiewak djspiewak merged commit e09738f into typelevel:series/3.x Jul 30, 2021
@armanbilge armanbilge mentioned this pull request Aug 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasilmkd vasilmkd vasilmkd approved these changes

@djspiewak djspiewak djspiewak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armanbilge @vasilmkd @djspiewak