Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global permissions #105

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Apr 27, 2022

PR adds the permissions section for generated workflow file.

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Apr 27, 2022

So a windows test seem to be failing but I am not sure if this related?

@mdedetrich mdedetrich force-pushed the add-global-permissions branch 2 times, most recently from b8e2846 to d7d0998 Compare April 30, 2022 10:09
@mdedetrich
Copy link
Contributor Author

mdedetrich commented Apr 30, 2022

So after looking at this again I have updated the PR with the following improvements

@mdedetrich mdedetrich force-pushed the add-global-permissions branch 2 times, most recently from 1d8f172 to 881ad03 Compare April 30, 2022 11:42
@mdedetrich
Copy link
Contributor Author

mdedetrich commented Jul 4, 2022

@djspiewak Would it be possible to have a look at this?

@TonioGela
Copy link

@djspiewak Would it be possible to have a look at this?

@djspiewak IMHO this pr has a huge value, and it's a feature that I'll love too

@mdedetrich
Copy link
Contributor Author

So from what I can see @djspiewak doesn't seem to have capacity/time to properly take care of this project hence why I made #117

@mdedetrich
Copy link
Contributor Author

@eed3si9n You mind looking at this?

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. if this passes the CI, I'd merge?

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Nov 28, 2022

Yup! I think the CI issues are unrelated but if needed I can look into it (I remember this project had windows related CI problems in general).

@mdedetrich mdedetrich force-pushed the add-global-permissions branch from 881ad03 to 781b9f5 Compare November 29, 2022 08:55
@TonioGela
Copy link

So from what I can see @djspiewak doesn't seem to have capacity/time to properly take care of this project hence why I made #117

It was moved! Awesome :D

@mdedetrich mdedetrich force-pushed the add-global-permissions branch from 781b9f5 to e7395e8 Compare January 4, 2023 09:59
@mdedetrich
Copy link
Contributor Author

@eed3si9n I will go ahead and merge this PR, just rebasing it now with the removal of the Windows in CI just to do a last minute sanity check to see it passes CI.

@mdedetrich mdedetrich merged commit 33838ba into sbt:main Jan 4, 2023
@mdedetrich mdedetrich deleted the add-global-permissions branch January 4, 2023 17:04
etspaceman added a commit to etspaceman/sbt-typelevel that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants