Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the code for publishing main branch snapshots #113

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented Jun 5, 2022

Haven't used this plugin before, but I believe that my reading comprehension skills are not fully broken and this is indeed a typo

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keynmol!

@eed3si9n eed3si9n merged commit caf6c9c into sbt:main Nov 27, 2022
@keynmol keynmol deleted the patch-1 branch November 27, 2022 21:07
@mzuehlke
Copy link

mzuehlke commented Feb 27, 2023

When reading the README.md I couldn't make sense out of the sentence

Note the use of `+=` rather than `:=`.

which after this change makes no sense anymore and should be removed.

Btw, as the default value is:

githubWorkflowPublishTargetBranches := Seq(RefPredicate.Equals(Ref.Branch("main")))

I don't see a typo here.

Got introduce here: 612e85d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants