Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/workflow support #65

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Feature/workflow support #65

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
10c5b24
Fix typo
987Nabil May 31, 2021
b27937b
Use simple generic workflow for internal workflow compilation
987Nabil Jun 1, 2021
f9ba5c6
Merge remote-tracking branch 'upstream/main' into feature/workflow-su…
987Nabil Jun 2, 2021
ba3975b
Separate files for Workflow, TriggerEvent and common RenderFunctions
987Nabil Jun 2, 2021
67e746f
Impl. ManualEvents
987Nabil Jun 3, 2021
df528f3
Impl. WebhookEvents
987Nabil Jun 7, 2021
d827cca
Generate custom workflows
987Nabil Jun 7, 2021
c228a3d
Do not use tags for pull request in ci workflow
987Nabil Jun 7, 2021
99c15d6
Docu for custom workflows
987Nabil Jun 8, 2021
c6f0a65
Paths for Push and PullRequest events
987Nabil Jun 8, 2021
153bb2d
Make Workflow jobs compile without oses
987Nabil Jun 14, 2021
33d6ee7
Introduce generation targets to adjust which workflows will be generated
987Nabil Jun 20, 2021
0ca4784
Merge remote-tracking branch 'upstream/main' into feature/workflow-su…
987Nabil Jul 19, 2021
132e807
Merge remote-tracking branch 'upstream/main' into feature/workflow-su…
987Nabil Aug 12, 2021
0ca1ced
Fix test expectation for path only rendering of pull request events
987Nabil Aug 12, 2021
f7d7603
Fix rendering in case of empty scalas
987Nabil Dec 29, 2021
c46d1cb
Support rendering without strategy/matrix
987Nabil Jan 11, 2022
1842373
Merge remote-tracking branch 'upstream/main' into feature/workflow-su…
987Nabil Jan 11, 2022
85702f8
Migrate custom workflows with main changes
987Nabil Jan 11, 2022
9c8bad7
Support for reusable workflows
987Nabil Jan 11, 2022
9fa66df
Check githubWorkflowIncludeClean to generate clean workflow as well
987Nabil Jan 11, 2022
fe9cacc
Fix reusable workflow rendering
987Nabil Jan 12, 2022
d09b0d7
Make reusable workflow jobs another class
987Nabil Jan 12, 2022
a945784
Merge remote-tracking branch 'upstream/main' into feature/workflow-su…
987Nabil Feb 3, 2023
7c90b65
Integrate permissions into the workflow DSL
987Nabil Feb 3, 2023
cf4f7ae
Regenerate workflows
987Nabil Feb 3, 2023
2a5dc1f
Adjust test expectations
987Nabil Feb 3, 2023
55e748d
Add GitHub doc links to Workflow DSL
987Nabil Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/main/scala/sbtghactions/GenerativePlugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,16 +617,6 @@ ${indentOnce(workflow.jobs.map(compileJob(_, sbt)).mkString("\n\n"))}
} else {
githubWorkflowSbtCommand.value
}
//compileWorkflow(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@987Nabil What is the context behind this test being commented, i.e. is it temporary to pass CI or is it intentional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was only an example I copied for how the current call looks like. I forgot to remove it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realised it is already gone.

// "Continuous Integration",
// githubWorkflowTargetBranches.value.toList,
// githubWorkflowTargetTags.value.toList,
// githubWorkflowTargetPaths.value,
// githubWorkflowPREventTypes.value.toList,
// githubWorkflowPermissions.value,
// githubWorkflowEnv.value,
// githubWorkflowGeneratedCI.value.toList,
// sbt)
compileWorkflow(
Workflow(
"Continuous Integration",
Expand Down Expand Up @@ -724,7 +714,6 @@ ${indentOnce(workflow.jobs.map(compileJob(_, sbt)).mkString("\n\n"))}
IO.write(ciYml, ciContents)
}

// TODO think about migration
if (targets(GenerationTarget.Clean) || includeClean) {
IO.write(cleanYml, cleanContents)
}
Expand Down
2 changes: 0 additions & 2 deletions src/sbt-test/sbtghactions/check-and-regenerate/expected-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@ on:
push:
branches: ['**']
tags: [v*]

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
build:
name: Build and Test
Expand Down
2 changes: 0 additions & 2 deletions src/sbt-test/sbtghactions/no-clean/.github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@ on:
branches: ['**']
push:
branches: ['**']

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
build:
name: Build and Test
Expand Down
2 changes: 0 additions & 2 deletions src/sbt-test/sbtghactions/non-existent-target/.github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@ on:
branches: ['**']
push:
branches: ['**']

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
build:
name: Build and Test
Expand Down
2 changes: 0 additions & 2 deletions src/sbt-test/sbtghactions/sbt-native-thin-client/.github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@ on:
branches: ['**']
push:
branches: ['**']

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
build:
name: Build and Test
Expand Down
2 changes: 0 additions & 2 deletions src/sbt-test/sbtghactions/suppressed-scala-version/expected-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@ on:
push:
branches: ['**']
tags: [v*]

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

jobs:
build:
name: Build and Test
Expand Down