Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for --chown flag for ADD/COPY Docker commands #1029

Closed
ahjohannessen opened this issue Sep 5, 2017 · 4 comments
Closed

Add support for --chown flag for ADD/COPY Docker commands #1029

ahjohannessen opened this issue Sep 5, 2017 · 4 comments
Labels
docker feature request

Comments

@ahjohannessen
Copy link

ahjohannessen commented Sep 5, 2017 •
edited
Loading

As --chown for ADD/COPY has landed in moby here: moby/moby#34263 I think it would be awesome if the following could be done:

  • check docker version using sys.process.Process (something a la docker version --format '{{.Server.Version}}' and if version is applicable then use --chown approach in order to save that notorious duplicate layer that doubles up on application size.

@muuki88 WDYT?
@muuki88
Copy link
Contributor

muuki88 commented Sep 6, 2017

I like the docker version idea. However I would persist the version in in a setting, e.g. dockerVersion.
We may be able to support different things base on that property.

Adding this chown feature would be really nice. Would you like to open a pull request for this?

@ahjohannessen
Copy link
Author

I like you version idea as well. I will look into it, because our images are unreasonably large.

@muuki88
Copy link
Contributor

muuki88 commented Sep 7, 2017

Thanks a lot . Looking forward 😍

mrfyda added a commit to mrfyda/sbt-native-packager that referenced this issue Oct 15, 2017
@mrfyda
Add support for --chown flag for ADD/COPY Docker commands
fecf78c 
Closes sbt#1029
@mrfyda mrfyda mentioned this issue Oct 15, 2017
Merged
muuki88 pushed a commit that referenced this issue Oct 22, 2017
@mrfyda @muuki88
Add support for --chown flag for ADD/COPY Docker commands (#1044)
42750a7 
* Add support for --chown flag for ADD/COPY Docker commands

Closes #1029

* Add dockerVersion for DockerSpotifyClient

* Extract docker version condition to DockerSupport

* Update documentation
@ahjohannessen
Copy link
Author

@muuki88 oh god OSS is great sometimes 😊 Was thinking about doing this next weekend and then some great champ chimes in and does it! Awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahjohannessen @muuki88