Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian plugin creates incorrect chown command #1151

Closed
mcenkar opened this issue Aug 26, 2018 · 1 comment
Closed

Debian plugin creates incorrect chown command #1151

mcenkar opened this issue Aug 26, 2018 · 1 comment

Comments

@mcenkar
Copy link
Contributor

mcenkar commented Aug 26, 2018

Expected behaviour

We are using DebianPackaging, and getting error on generated chown command.

In generated postinst there is:

# Chown definitions created by SBT Native Packager

a_lot_of_files_and_then_this_one
chown website:website /usr/share/project-name/share/doc/api/website/engine/utils/Binders$$WknsBinder$.html

But when running it it gives error:

Binders33321WknsBinder$.html': No such file or directory

because $$ is replaced with PID. Generated command should surround filepath with single quotes, e.g.:

chown website:website '/usr/share/project-name/share/doc/api/website/engine/utils/Binders$$WknsBinder$.html'

Actual behaviour

Incorrect chown command.

Information

  • What sbt-native-packager are you using

1.3.4.

Error seems to be here: https://github.com/sbt/sbt-native-packager/blob/v1.3.6/src/main/scala/com/typesafe/sbt/packager/debian/DebianPlugin.scala#L422, no quote around $path.

mcenkar added a commit to mcenkar/sbt-native-packager that referenced this issue Aug 26, 2018
mcenkar added a commit to mcenkar/sbt-native-packager that referenced this issue Aug 26, 2018
mcenkar added a commit to mcenkar/sbt-native-packager that referenced this issue Aug 26, 2018
mcenkar added a commit to mcenkar/sbt-native-packager that referenced this issue Aug 27, 2018
@mcenkar
Copy link
Contributor Author

mcenkar commented Sep 3, 2018

Fixed in 1.3.7.

@mcenkar mcenkar closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants