Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowsPlugin: support multiple .wxs inputs #1176

Closed
nigredo-tori opened this issue Nov 27, 2018 · 1 comment
Closed

WindowsPlugin: support multiple .wxs inputs #1176

nigredo-tori opened this issue Nov 27, 2018 · 1 comment

Comments

@nigredo-tori
Copy link
Collaborator

nigredo-tori commented Nov 27, 2018

This would be useful when working with custom WiX scripts - for example, when harvesting a directory using heat. Since heat generates a separate .wxs file, the only option to use it with the current packageBin implementation would be transforming it to an include file, which is incredibly ugly, and would require working around the copy logic.

Both candle and light support using multiple input files, so implementing this feature can be as simple as replacing wixFile: TaskKey[File] with wixFiles: TaskKey[Seq[File]], and updating packageBin implementation accordingly. If there's a need to preserve compatibility with the code that uses wixFile, we can keep wixFile and just do this:

wixFiles := List(wixFile.value)
@muuki88
Copy link
Contributor

muuki88 commented Nov 27, 2018

Thanks for this feature request. Would you like to make a pull request for this?

muuki88 pushed a commit that referenced this issue Nov 29, 2018
* Implement building from multiple WiX sources

* Add a test for custom WiX sources in WindowsPlugin

* Fix code formatting

* Remove unnecessary overwrite flag

* Fix for SBT 0.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants