Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerLayerGrouping in Docker := (_ => None) does not work #1341

Closed
DieBauer opened this issue May 19, 2020 · 1 comment · Fixed by #1369
Closed

dockerLayerGrouping in Docker := (_ => None) does not work #1341

DieBauer opened this issue May 19, 2020 · 1 comment · Fixed by #1369
Labels
docker documentation Documentation should be extended or updated

Comments

@DieBauer
Copy link
Contributor

Expected behaviour

dockerLayerGrouping in Docker  := (_ => None)

As described in the 1.7.0 release notes, disables layering of dependencies in 1/opt and 2/opt.

Actual behaviour

Still creates layer folders.

There is a test in https://github.com/sbt/sbt-native-packager/blob/master/src/sbt-test/docker/test-layer-groups/changes/nolayers.sbt

That does succeed, but that is not using the advertised dockerLayerGrouping but dockerGroupLayers. Changing this in the test to the advertised statement fails the test.

Is this a bug in the release notes, should it become dockerGroupLayers in Docker := PartialFunction.empty?

Information

  • What sbt-native-packager are you using
    1.7.1
  • What sbt version
    1.3.10
  • What is your build system (e.g. Ubuntu, MacOS, Windows, Debian )
    Ubuntu and MacOS
  • What package are you building (e.g. docker, rpm, ...)
    docker
  • What version has your build tool (find out with e.g. rpm --version)
    RPM version 4.14.2.1
  • What is your target system (e.g. Ubuntu 16.04, CentOS 7)
    CentOS8
@muuki88 muuki88 added docker documentation Documentation should be extended or updated labels May 22, 2020
@muuki88
Copy link
Contributor

muuki88 commented May 22, 2020

Thanks for reporting this along with providing a fix ♥️

Would you like to open a pull request and fix the docs? This has been introduced in a last pull request, which is hard to find on my phone 😅

DieBauer added a commit to DieBauer/sbt-native-packager that referenced this issue Oct 1, 2020
Fixes sbt#1341 

Since 1.7.1 dockerLayerGrouping is deprecated. 

Rename the setting, and add the correct 'disable' statement.
muuki88 pushed a commit that referenced this issue Oct 4, 2020
Fixes #1341 

Since 1.7.1 dockerLayerGrouping is deprecated. 

Rename the setting, and add the correct 'disable' statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker documentation Documentation should be extended or updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants