Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDKPackagerPlugin fails to build package if maintainer is not set #563

Closed
strobe opened this issue Apr 26, 2015 · 8 comments
Closed

JDKPackagerPlugin fails to build package if maintainer is not set #563

strobe opened this issue Apr 26, 2015 · 8 comments

Comments

@strobe
Copy link

strobe commented Apr 26, 2015

Got this error even if main class was set at build.sbt manually (on OSX).

[error] Exception in thread "main" com.sun.javafx.tools.packager.PackagerException: Error: Unknown argument: hello.ScalaFXHelloWorld
[error]     at com.sun.javafx.tools.packager.Main.main(Main.java:340)

as example of ScalaFX app see https://github.com/scalafx/scalafx-hello-world/blob/master/src/main/scala/hello/ScalaFXHelloWorld.scala

@muuki88
Copy link
Contributor

muuki88 commented Apr 27, 2015

Is this a sbt-native-packager error? For me it looks more like a general sbt/javafx missconfiguration?

cc @metasim

@metasim
Copy link
Member

metasim commented Apr 27, 2015

@strobe What version of Java and JavaFX are you using?

Also, can you include your build.sbt file?

@strobe
Copy link
Author

strobe commented Apr 28, 2015

I'm using this

java version "1.8.0_45"
Java(TM) SE Runtime Environment (build 1.8.0_45-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)

I created simple project for test this issue

https://github.com/strobe/ScalaFxPackaging

@metasim
Copy link
Member

metasim commented Apr 28, 2015

@strobe Thanks a lot. Will take a look at it soon.

@metasim
Copy link
Member

metasim commented Apr 28, 2015

I don't think the bug has anything to do with ScalaFX, but with the plugin improperly handling the case when no maintainer is specified.

@strobe Working on a fix, but try setting the maintainer key and see if you get a package out of it.

@muuki88 Could you please change the title of this issue to: "JDKPackagerPlugin fails to build package if maintainer is not set."?

metasim pushed a commit to metasim/sbt-native-packager that referenced this issue Apr 28, 2015
@strobe
Copy link
Author

strobe commented Apr 28, 2015

@metasim
checked - yes it working well if maintainer was set

@metasim
Copy link
Member

metasim commented Apr 28, 2015

PR submitted.

muuki88 added a commit that referenced this issue Apr 29, 2015
@muuki88
Copy link
Contributor

muuki88 commented Apr 29, 2015

fix with #566

@muuki88 muuki88 closed this as completed Apr 29, 2015
@muuki88 muuki88 changed the title JDKPackagerPlugin can't package ScalaFX application DKPackagerPlugin fails to build package if maintainer is not set Apr 29, 2015
@muuki88 muuki88 changed the title DKPackagerPlugin fails to build package if maintainer is not set JDKPackagerPlugin fails to build package if maintainer is not set Apr 29, 2015
@muuki88 muuki88 added the bug label Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants