-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto plugins are required to declare their project configurations #676
Labels
Comments
So for example our object autoImport extends DockerKeys {
val Docker = config("docker") extend Universal
}
import autoImport._
override def projectConfigurations: Seq[Configuration] = Docker :: Nil Does this have any effect on existing behaviour? |
I understand that adding it is benign. |
I took a look at the sbt source and the auto plugin config sequence is prepended to any user supplied config via this override. Perhaps @eed3si9n can confirm the effect of overriding the method as the right thing to do though. |
muuki88
added a commit
that referenced
this issue
Mar 20, 2016
muuki88
added a commit
that referenced
this issue
Mar 28, 2016
FIX #676 adding configuration scopes to project configurations
Nice work! |
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Auto plugins are required to register any configurations that they may introduce in order to allow a user to declare any addition configurations of their own. For example, given some other configuration named
Backend
:...a
bundle:dist
will subsequently fail as the plugin's configurations are effectively zapped.Each new auto plugin that introduces a configuration should declare the configurations that it provides so that they may be prepended to declarations such as the one above. The method to override for each auto plugin is
projectConfigurations
. Here's an example from sbt-bundle (pending a PR):The text was updated successfully, but these errors were encountered: