Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for docker build args #844

Closed
rsemlal opened this issue Jul 12, 2016 · 4 comments
Closed

Adding support for docker build args #844

rsemlal opened this issue Jul 12, 2016 · 4 comments
Labels
docker feature request

Comments

@rsemlal
Copy link

rsemlal commented Jul 12, 2016

During docker:publishLocal, it would be nice to be able to customize the docker build command or at least having support for adding docker build args (https://docs.docker.com/engine/reference/commandline/build/#/set-build-time-variables-build-arg)
@muuki88 muuki88 added the docker label Jul 12, 2016
@muuki88
Copy link
Contributor

muuki88 commented Jul 12, 2016

I posted a suggestion on how to implement this here #806 Maybe you can try a pull request?

makubi added a commit to makubi/sbt-native-packager that referenced this issue Jul 24, 2016
@makubi
Adding 'dockerBuildCommand' and 'dockerBuildOptions'
779b5f7 
TODO: Write summary

Fixes sbt#844.
@NeQuissimus
Copy link
Contributor

Is this not solved by #854 ?

@muuki88
Copy link
Contributor

muuki88 commented Apr 17, 2017

True! Thanks for mentioning 😃

@muuki88 muuki88 closed this as completed Apr 17, 2017
@pawelkaczor
Copy link
Contributor

The support for docker build options (#854) is not enough. The Docker build args require the ARG instruction in the Dockerfile:
https://docs.docker.com/engine/reference/builder/#arg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pawelkaczor @NeQuissimus @muuki88 @rsemlal