-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker:publish should skip non-Docker projects #974
Comments
ok, somebody added a |
Hm. Setting a key enables the plugin? That wouldn't be very intuitive IMHO |
aha! The problem seems to be with |
So when you start your example project and list the plugins in sbt with |
Ahhh.. I have a guess. The I guess these lines are responsible that the What does So, the quick fix is to override the |
Why was this closed? Still seems to be an issue |
I closed this as there wasn't any activity for a long time. Feel free to open a pull request if this is an issue for you 😃 If you need any guidance aside from the comments above, don't hesitate to ask. |
From @nigredo-tori The issue here is that
As a quick workaround, you can add a plugin like this: object DockerForwardPlugin extends AutoPlugin {
override requires = DockerPlugin
override trigger = allRequirements
object autoImport {
val forwardedDockerPublish = taskKey[Unit]("Docker/publish for projects with DockerPlugin")
}
import autoImport._
val projectSettings = Seq(
forwardedDockerPublish := (Docker / publish).value
)
} , and use |
cheating a bit, this short test project for this standardisation plugin (the vast majority of which can be ignored)
https://github.com/cakesolutions/sbt-cake/blob/master/src/sbt-test/sbt-cake/simple/build.sbt
defines 3 projects, only two of which enable the
DockerPlugin
. If I typesbt docker:publishLocal
it bails when it hits thelogging
project. But since the plugin hasn't been enabled I would have expected it to just skip this project, much asit:test
only runs for projects with integration tests.The text was updated successfully, but these errors were encountered: