Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recipe for setting umask #1038

Merged
merged 2 commits into from
Oct 21, 2017
Merged

Add recipe for setting umask #1038

merged 2 commits into from
Oct 21, 2017

Conversation

keirlawson
Copy link
Contributor

Closes #1032

muuki88
muuki88 requested changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 😍

Only a small remark. I won't be able to merge this until end of October as I'm on vacation and the Travis build started to have some issues.

src/sphinx/recipes/umask.rst Outdated

When using a linux package such as a RPM or Deb, the umask, associated with the user running the process,
will determine what permissions files generated by the process, such as log file, will have. Usually the system default umask
for daemons is fine and can be left unchanged, however sometime the need arises to oerride it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we should add a hint that this requires the JavaAppServerPackaging

muuki88
muuki88 approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mate 😊

erickpintor
erickpintor suggested changes Sep 28, 2017
View reviewed changes
src/sphinx/recipes/umask.rst

When using the :ref:`java-server-plugin`, the umask, associated with the user running the process,
will determine what permissions files generated by the process, such as log file, will have. Usually the system default umask
for daemons is fine and can be left unchanged, however sometime the need arises to oerride it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a typo in "oerride".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 😘

@muuki88 muuki88 merged commit 2a8370d into sbt:master Oct 21, 2017
@muuki88 muuki88 added the documentation Documentation should be extended or updated label Oct 21, 2017
@keirlawson keirlawson deleted the patch-1 branch October 23, 2017 09:08
@mkurz
Copy link
Member

mkurz commented Nov 2, 2019

Added docs for a more general way how to set umask, not just when using System V/systemd: #1274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

@erickpintor erickpintor erickpintor requested changes

Assignees
No one assigned
Labels
documentation Documentation should be extended or updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide means to set umask of user?
4 participants
@keirlawson @mkurz @muuki88 @erickpintor