Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerVersion command creation #1052

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Conversation

mrfyda
Copy link
Contributor

@mrfyda mrfyda commented Oct 24, 2017

Fixes #1051

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix ❤️

@muuki88 muuki88 merged commit e5f1a91 into sbt:master Oct 24, 2017
@muuki88
Copy link
Contributor

muuki88 commented Oct 24, 2017

@mrfyda are you interested in becoming more involved with sbt-native-packager?
I'm more than happy to have more people on board maintaining this project :)

@mrfyda mrfyda deleted the fix-docker-version-cmd branch October 24, 2017 10:11
@NeQuissimus
Copy link
Contributor

@muuki88 Can you cut a release for this?

@muuki88
Copy link
Contributor

muuki88 commented Oct 24, 2017

I'll try ASAP when I'm back from work.

@NeQuissimus
Copy link
Contributor

Thank you :)

@muuki88
Copy link
Contributor

muuki88 commented Oct 24, 2017

1.3.1 is out

@mrfyda
Copy link
Contributor Author

mrfyda commented Oct 25, 2017

@muuki88 Thanks for the release. Let me know how I can help.

@muuki88
Copy link
Contributor

muuki88 commented Nov 4, 2017

Sorry, lost track of your answer 😄
Any help is welcome. You are already contributing well done code contributions.
I'm giving you commit rights, so you could review and merge other peoples PRs
if you feel comfortable doing so and have the time and motivation to.

Even if this sounds obvious: Everything, yet so seemingly small help, is awesome,
but if you aren't forced to do anything. The native-packager community is small,
with friendly, helpful and open-minded people. It should always be enjoyable
contributing here 😃

If you like, we can hangout/skype 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants