Fix duplicate application.ini mappings when both BASH and BAT plugins are used #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwickern
force-pushed
the
duplicate-application-ini
branch
from
15d685c to
c3e6ca8
Compare
muuki88
approved these changes
Oct 29, 2017
| "application.ini is already present in output package. Will be overridden by 'javaOptions in Universal'" | ||
| ) | ||
| val filteredMappings = universalMappings.filter { | ||
| case (`configFile`, `pathMapping`) => |
There was a problem hiding this comment.
Interesting implementation. I didn't get at first what was happening here. The second call to the method
will filter the already created config file.
|
nevermind the revert branch. I overlooked that the validateBash tests were failing, but it was a travis issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the BAT plugin supports application.ini, when you use both plugins together you get duplicate mappings:
This isn't necessarily a problem, but unzipping the universal dist will try to create the file twice:
This change filters out the duplicate mapping. Alternatively maybe it would be better to have an
ApplicationIniPluginwhich is a dependency of both theBatStartScriptPluginandBashStartScriptPlugin